patch 'cryptodev: fix device socket ID type' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Thu Aug 10 02:06:46 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=330800b7d5d592c28c783de929b2631e8b8a62a6

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 330800b7d5d592c28c783de929b2631e8b8a62a6 Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Wed, 5 Jul 2023 10:36:30 +0000
Subject: [PATCH] cryptodev: fix device socket ID type
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit f31af82a8bc130712188668bc2b7cd395ef8920d ]

The socket ID field for a cryptodev device data was unsigned int.
Due to recent changes to the default device socket ID,
this caused an issue when the socket ID was unknown and set to -1.
The device socket ID wrapped around to 255,
and caused errors when allocating memory.

Changing this field type to int fixes the issue, as it now takes the
correct -1 value.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Morten Brørup <mb at smartsharesystems.com>
Acked-by: Kai Ji <kai.ji at intel.com>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev at yandex.ru>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
 lib/cryptodev/cryptodev_pmd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
index 0020102eb7..8c1467037e 100644
--- a/lib/cryptodev/cryptodev_pmd.h
+++ b/lib/cryptodev/cryptodev_pmd.h
@@ -65,7 +65,7 @@ struct rte_cryptodev_data {
 	/** Device ID for this instance */
 	uint8_t dev_id;
 	/** Socket ID where memory is allocated */
-	uint8_t socket_id;
+	int socket_id;
 	/** Unique identifier name */
 	char name[RTE_CRYPTODEV_NAME_MAX_LEN];
 
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-08-09 21:51:20.678746100 +0800
+++ 0097-cryptodev-fix-device-socket-ID-type.patch	2023-08-09 21:51:18.264352000 +0800
@@ -1 +1 @@
-From f31af82a8bc130712188668bc2b7cd395ef8920d Mon Sep 17 00:00:00 2001
+From 330800b7d5d592c28c783de929b2631e8b8a62a6 Mon Sep 17 00:00:00 2001
@@ -7,0 +8,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit f31af82a8bc130712188668bc2b7cd395ef8920d ]
@@ -19 +21,0 @@
-Cc: stable at dpdk.org
@@ -31 +33 @@
-index 8710ed7558..4c98cedca6 100644
+index 0020102eb7..8c1467037e 100644


More information about the stable mailing list