patch 'examples/l3fwd: fix duplicate expression for default nexthop' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Thu Aug 10 02:06:51 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/11/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=9f9ea16ee2e6c799f56399aaa4dd7f64437ace72

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 9f9ea16ee2e6c799f56399aaa4dd7f64437ace72 Mon Sep 17 00:00:00 2001
From: Mohammad Iqbal Ahmad <mahmad at marvell.com>
Date: Tue, 10 Jan 2023 20:26:13 +0530
Subject: [PATCH] examples/l3fwd: fix duplicate expression for default nexthop
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 9a518054b5551576745a89c1cf60301655c03a9b ]

This patch fixes (Logically dead code) coverity issue.
This patch also fixes (Uninitialized scalar variable) coverity issue.

Coverity issue: 381687, 381686
Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method")

Signed-off-by: Mohammad Iqbal Ahmad <mahmad at marvell.com>
Acked-by: Conor Walsh <conor.walsh at intel.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
---
 examples/l3fwd/l3fwd_fib.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/examples/l3fwd/l3fwd_fib.c b/examples/l3fwd/l3fwd_fib.c
index edc0dd69b9..18398492ae 100644
--- a/examples/l3fwd/l3fwd_fib.c
+++ b/examples/l3fwd/l3fwd_fib.c
@@ -359,10 +359,10 @@ fib_event_loop(struct l3fwd_event_resources *evt_rsrc,
 				nh = (uint16_t)hopsv4[ipv4_arr_assem++];
 			else
 				nh = (uint16_t)hopsv6[ipv6_arr_assem++];
-			if (nh != FIB_DEFAULT_HOP)
-				hops[i] = nh != FIB_DEFAULT_HOP ?
-						  nh :
-						  events[i].mbuf->port;
+
+			hops[i] = nh != FIB_DEFAULT_HOP ?
+				  nh :
+				  events[i].mbuf->port;
 			process_packet(events[i].mbuf, &hops[i]);
 			events[i].mbuf->port = hops[i] != BAD_PORT ?
 						       hops[i] :
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-08-09 21:51:20.797561100 +0800
+++ 0102-examples-l3fwd-fix-duplicate-expression-for-default-.patch	2023-08-09 21:51:18.264352000 +0800
@@ -1 +1 @@
-From 9a518054b5551576745a89c1cf60301655c03a9b Mon Sep 17 00:00:00 2001
+From 9f9ea16ee2e6c799f56399aaa4dd7f64437ace72 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 9a518054b5551576745a89c1cf60301655c03a9b ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list