[PATCH v2] bus/pci: fix legacy device IO port map in secondary process

[Ma, WenwuX]

Hi,

> -----Original Message-----
> From: Stephen Hemminger <stephen at networkplumber.org>
> Sent: 2023年8月21日 10:53
> To: Ma, WenwuX <wenwux.ma at intel.com>
> Cc: nipun.gupta at amd.com; dev at dpdk.org; david.marchand at redhat.com;
> maxime.coquelin at redhat.com; Xia, Chenbo <chenbo.xia at intel.com>; Li,
> Miao <miao.li at intel.com>; Ling, WeiX <weix.ling at intel.com>;
> stable at dpdk.org
> Subject: Re: [PATCH v2] bus/pci: fix legacy device IO port map in secondary
> process
> 
> On Mon, 21 Aug 2023 09:27:07 +0800
> Wenwu Ma <wenwux.ma at intel.com> wrote:
> 
> > +	struct vfio_device_info device_info = { .argsz = sizeof(device_info) };
> > +	char pci_addr[PATH_MAX] = {0}
> 
> Not sure if some tools will complain about initializing chars as zero.
> Anyway, why bother since you are using it with snprintf.
> 
> Also, the new variables that are only used in the secondary case should be
> declared in that if() not for whole function.
> 
> 
Ok, thanks