[PATCH v5 01/12] common/cnxk: use unique name for DPI memzone

Jerin Jacob jerinjacobk at gmail.com
Wed Aug 23 17:30:45 CEST 2023


On Wed, Aug 23, 2023 at 4:45 PM Amit Prakash Shukla
<amitprakashs at marvell.com> wrote:
>
> roc_dpi was using vfid as part of name for memzone allocation.
> This led to memzone allocation failure in case of multiple
> physical functions. vfid is not unique by itself since multiple
> physical functions can have the same virtual function indices.
> So use complete DBDF as part of memzone name to make it unique.
>
> Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support")
> Cc: stable at dpdk.org
>
> Signed-off-by: Radha Mohan Chintakuntla <radhac at marvell.com>
> Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>


Updated the git commit as follows and series applied to
dpdk-next-net-mrvl/for-next-net. Thanks


commit 33e784c82a1f0e97cbc10e5a5bcd0bdc4738b3de (HEAD -> for-next-net)
Author: Vamsi Attunuru <vattunuru at marvell.com>
Date:   Wed Aug 23 16:45:25 2023 +0530

    dma/cnxk: track last index return value

    Last index value might lost the order when dma stats are reset
    in between copy operations. Patch adds a variable to track the
    completed count, that can be used to compute the last index, also
    patch adds misc other changes.

    Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>

commit 93d72a0046aa924b9f36848b73027c181347c9e8
Author: Vamsi Attunuru <vattunuru at marvell.com>
Date:   Wed Aug 23 16:45:24 2023 +0530

    dma/cnxk: fix completion ring tail wrap

    Adds a check to avoid tail wrap when completion desc ring
    is full. Also patch increase max desc size to 2048.

    Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations")
    Fixes: 3340c3e22783 ("dma/cnxk: add scatter-gather copy")
    Fixes: 681851b347ad ("dma/cnxk: support CN10K DMA engine")
    Cc: stable at dpdk.org

    Signed-off-by: Vamsi Attunuru <vattunuru at marvell.com>

commit 71d2cd2221fcd4715eb33a866a33ba8bc8be54f5
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:23 2023 +0530

    dma/cnxk: enhance vchan support

    Added changes to realign dpi private structure based on vchan.
    Also resets DMA dev stats while starting dma device.

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit 370fabc5515b3b459c0bf21596a26bd3ca754bf8
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:22 2023 +0530

    dma/cnxk: increase vchan per queue to max 4

    To support multiple directions in same queue make use of multiple vchan
    per queue. Each vchan can be configured in some direction and used.

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>
    Signed-off-by: Radha Mohan Chintakuntla <radhac at marvell.com>

commit 495d2689eb21fffe0c2cc9a090971f656c736770
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:21 2023 +0530

    dma/cnxk: update func field based on transfer type

    Use pfid and vfid of src_port for incoming DMA transfers and dst_port
    for outgoing DMA transfers.

    Signed-off-by: Radha Mohan Chintakuntla <radhac at marvell.com>
    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit b938db4eb11b4b9dfdd9929516cdb9d714942189
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:20 2023 +0530

    dma/cnxk: support all models of cn10xxx

    Valid function pointers are set for DMA device operations
    i.e. cn10k_dmadev_ops are used for all cn10k devices.

    Signed-off-by: Radha Mohan Chintakuntla <radhac at marvell.com>
    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit a3b4b6da918c7380d9ffbf24f670c4bcf1e27494
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:19 2023 +0530

    dma/cnxk: fix chunk buffer failure return code

    On chunk buffer alloc failure, ENOMEM is returned. As per DMA spec
    ENOSPC shall be returned on failure to allocate memory. This
    changeset fixes the same.

    Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations")
    Cc: stable at dpdk.org

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit 28392a849e9e04040ad49a3c61d0d0f3f39ff6e3
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:18 2023 +0530

    dma/cnxk: make completion ring buffer as dynamic

    Completion buffer was a static array per dma device. This would
    consume memory for max number of descriptor supported by device
    which might be more than configured by application. The change
    allocates the memory for completion buffer based on the number
    of descriptor configured by application.

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:17 2023 +0530

    dma/cnxk: fix device reconfigure

    Multiple call to configure, setup queues without stopping the device
    would leak the ring descriptor and hardware queue memory. This patch
    adds flags support to prevent configuring without stopping the
    device.

    Fixes: b56f1e2dad38 ("dma/cnxk: add channel operations")
    Cc: stable at dpdk.org

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit d32fabfad6a62959d2196a342605f64b787cd936
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:16 2023 +0530

    dma/cnxk: fix device state

    When a device is not set to a ready state, on exiting the application
    proper cleanup is not done. This causes the application to fail on
    trying to run next time.

    Setting the device to ready state on successful probe fixes the issue.

    Fixes: 53f6d7328bf4 ("dma/cnxk: create and initialize device on
PCI probing")
    Cc: stable at dpdk.org

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit 8c0b8bfa4b7d6ead026d2e22ac91f219303baa30
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:15 2023 +0530

    dma/cnxk: support for burst capacity

    Adds support for the burst capacity. Call to the function return
    number of vacant space in descriptor ring for the current burst.

    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>

commit 9b6dc3fc98ad0be2f45b6eadbd88e13f0f0e1492
Author: Amit Prakash Shukla <amitprakashs at marvell.com>
Date:   Wed Aug 23 16:45:14 2023 +0530

    common/cnxk: fix DPI memzone name

    roc_dpi was using vfid as part of name for memzone allocation.
    This led to memzone allocation failure in case of multiple
    physical functions. vfid is not unique by itself since multiple
    physical functions can have the same virtual function indices.
    So use complete DBDF as part of memzone name to make it unique.

    Fixes: b6e395692b6d ("common/cnxk: add DPI DMA support")
    Cc: stable at dpdk.org

    Signed-off-by: Radha Mohan Chintakuntla <radhac at marvell.com>
    Signed-off-by: Amit Prakash Shukla <amitprakashs at marvell.com>


More information about the stable mailing list