patch 'net/virtio: fix missing next flag in Tx packed ring' has been queued to stable release 22.11.4

Xueming Li xuemingl at nvidia.com
Mon Dec 11 11:10:30 CET 2023


Hi,

FYI, your patch has been queued to stable release 22.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/13/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=b485fae237054b241cec32a3b7e13c4204d6ffbf

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From b485fae237054b241cec32a3b7e13c4204d6ffbf Mon Sep 17 00:00:00 2001
From: Fengjiang Liu <liufengjiang.0426 at bytedance.com>
Date: Tue, 17 Oct 2023 15:26:23 +0800
Subject: [PATCH] net/virtio: fix missing next flag in Tx packed ring
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit f923636411c557782f4718de8bee856d60afa74c ]

When the packets is sent in packed mode, and the packets data and
virtio-header are divided into two desc, set the next flag of
virtio-header desc

Bugzilla ID: 1295
Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")

Signed-off-by: Fengjiang Liu <liufengjiang.0426 at bytedance.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 .mailmap                       | 1 +
 drivers/net/virtio/virtqueue.h | 1 +
 2 files changed, 2 insertions(+)

diff --git a/.mailmap b/.mailmap
index 83b960753a..a1ff0137a7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -380,6 +380,7 @@ Farah Smith <farah.smith at broadcom.com>
 Fei Chen <chenwei.0515 at bytedance.com>
 Feifei Wang <feifei.wang2 at arm.com> <feifei.wang at arm.com>
 Fei Qin <fei.qin at corigine.com>
+Fengjiang Liu <liufengjiang.0426 at bytedance.com>
 Fengnan Chang <changfengnan at bytedance.com>
 Fengtian Guo <fengtian.guo at 6wind.com>
 Ferdinand Thiessen <rpm at fthiessen.de>
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index f5d8b40cad..5c9230cfe1 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -771,6 +771,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
 		start_dp[idx].addr  = txvq->virtio_net_hdr_mem +
 			RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
 		start_dp[idx].len   = vq->hw->vtnet_hdr_size;
+		head_flags |= VRING_DESC_F_NEXT;
 		hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
 		idx++;
 		if (idx >= vq->vq_nentries) {
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-12-11 17:56:23.418783700 +0800
+++ 0005-net-virtio-fix-missing-next-flag-in-Tx-packed-ring.patch	2023-12-11 17:56:22.877652300 +0800
@@ -1 +1 @@
-From f923636411c557782f4718de8bee856d60afa74c Mon Sep 17 00:00:00 2001
+From b485fae237054b241cec32a3b7e13c4204d6ffbf Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit f923636411c557782f4718de8bee856d60afa74c ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +24 @@
-index 3f5bab26a8..5273df74cb 100644
+index 83b960753a..a1ff0137a7 100644
@@ -25 +27 @@
-@@ -394,6 +394,7 @@ Farah Smith <farah.smith at broadcom.com>
+@@ -380,6 +380,7 @@ Farah Smith <farah.smith at broadcom.com>
@@ -34 +36 @@
-index c1cb941c43..5d0c0399a8 100644
+index f5d8b40cad..5c9230cfe1 100644
@@ -37,4 +39,4 @@
-@@ -682,6 +682,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
- 		 */
- 		start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
- 		start_dp[idx].len = vq->hw->vtnet_hdr_size;
+@@ -771,6 +771,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
+ 		start_dp[idx].addr  = txvq->virtio_net_hdr_mem +
+ 			RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
+ 		start_dp[idx].len   = vq->hw->vtnet_hdr_size;


More information about the stable mailing list