patch 'net/mlx5: fix flow thread safety flag for HWS' has been queued to stable release 22.11.4

Xueming Li xuemingl at nvidia.com
Mon Dec 11 11:11:15 CET 2023


Hi,

FYI, your patch has been queued to stable release 22.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 12/13/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=815a8ce0676466e10341db5c7d3950a05c7f0673

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 815a8ce0676466e10341db5c7d3950a05c7f0673 Mon Sep 17 00:00:00 2001
From: Dariusz Sosnowski <dsosnowski at nvidia.com>
Date: Mon, 23 Oct 2023 13:23:02 +0300
Subject: [PATCH] net/mlx5: fix flow thread safety flag for HWS
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit df26aa6e1ffc16d38424634b6fd83093eaa7abdf ]

When mlx5 port was configured with HW Steering flow engine
(devarg dv_flow_en set to 2), PMD did not set
RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE in device flags.
This caused certain flow API calls, such as rte_flow_query(),
to obtain a port-wide lock, which is not needed.

This patch adds missing code for setting this flag.

Fixes: d84c3cf7662c ("net/mlx5: introduce hardware steering enable routine")

Signed-off-by: Dariusz Sosnowski <dsosnowski at nvidia.com>
Acked-by: Suanming Mou <suanmingm at nvidia.com>
---
 drivers/net/mlx5/linux/mlx5_os.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 6fdade7dab..438b832a40 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -1629,6 +1629,7 @@ err_secondary:
 					 "matching is disabled",
 				eth_dev->data->port_id);
 		}
+		eth_dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE;
 		return eth_dev;
 #else
 		DRV_LOG(ERR, "DV support is missing for HWS.");
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-12-11 17:56:24.775823000 +0800
+++ 0050-net-mlx5-fix-flow-thread-safety-flag-for-HWS.patch	2023-12-11 17:56:23.017652300 +0800
@@ -1 +1 @@
-From df26aa6e1ffc16d38424634b6fd83093eaa7abdf Mon Sep 17 00:00:00 2001
+From 815a8ce0676466e10341db5c7d3950a05c7f0673 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit df26aa6e1ffc16d38424634b6fd83093eaa7abdf ]
@@ -15 +17,0 @@
-Cc: stable at dpdk.org
@@ -24 +26 @@
-index 2e501bf4ec..2f08f2354e 100644
+index 6fdade7dab..438b832a40 100644
@@ -27 +29 @@
-@@ -1614,6 +1614,7 @@ err_secondary:
+@@ -1629,6 +1629,7 @@ err_secondary:


More information about the stable mailing list