[PATCH v5 1/2] net/iavf: fix Tx path error in multi-process

Zhang, Qi Z qi.z.zhang at intel.com
Thu Dec 28 11:50:05 CET 2023



> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye at intel.com>
> Sent: Thursday, December 28, 2023 6:26 PM
> To: dev at dpdk.org
> Cc: Yang, Qiming <qiming.yang at intel.com>; Ye, MingjinX
> <mingjinx.ye at intel.com>; stable at dpdk.org; Wu, Jingjing
> <jingjing.wu at intel.com>; Xing, Beilei <beilei.xing at intel.com>
> Subject: [PATCH v5 1/2] net/iavf: fix Tx path error in multi-process
>
> In a multi-process environment, a secondary process operates on shared
> memory and changes the PMD transmit function pointer of the primary
> process, causing the primary process to send pkts without being able to find
> the function address, resulting in a crash.
>
> Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down")
> Cc: stable at dpdk.org

Should Rx also need to be fixed? please make a complete fix.

>
> Signed-off-by: Mingjin Ye <mingjinx.ye at intel.com>
> ---
>  drivers/net/iavf/iavf.h      | 12 +++++++++++-
>  drivers/net/iavf/iavf_rxtx.c | 34 +++++++++++++++++++++++++++++++---
>  drivers/net/iavf/iavf_rxtx.h |  3 +++
>  3 files changed, 45 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index
> 10868f2c30..4cd5bea167 100644
> --- a/drivers/net/iavf/iavf.h
> +++ b/drivers/net/iavf/iavf.h
> @@ -313,6 +313,16 @@ struct iavf_devargs {
>
>  struct iavf_security_ctx;
>
> +enum iavf_tx_pkt_burst_type {
> +     IAVF_PKT_BURST_DEFAULT          = 0,
> +     IAVF_PKT_BURST_VEC              = 1,

Better to rename with  xxx_VEC_SSE




More information about the stable mailing list