patch 'vdpa/ifc: fix reconnection in SW-assisted live migration' has been queued to stable release 20.11.8

luca.boccassi at gmail.com luca.boccassi at gmail.com
Thu Feb 23 10:36:19 CET 2023


Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/eb73764d1146069bb3ffbcfb88e0928ef9c4b525

Thanks.

Luca Boccassi

---
>From eb73764d1146069bb3ffbcfb88e0928ef9c4b525 Mon Sep 17 00:00:00 2001
From: Andy Pei <andy.pei at intel.com>
Date: Mon, 12 Dec 2022 15:12:45 +0800
Subject: [PATCH] vdpa/ifc: fix reconnection in SW-assisted live migration

[ upstream commit ef3be7e237dd707f46870b09b93f88f8ee5e75c6 ]

In the case using argument "sw-live-migration=1" to enable SW assisted live
migration, we take QEMU as front end for example, after source VM migrates
to destination VM, we keep vdpa process for source VM there, we kill the
QEMU process for source VM, and restart the QEMU process for source VM.
In this case, vdpa driver will not perform DMA map and data path will not
work properly.

The above case works fine in the case "sw-live-migration=0".

The root cause is that current code driver does not set running flag to 0.
Driver treats device as ruuning and does not perform DMA map.

Fixes: 4bb531e152d3 ("net/ifc: support SW assisted VDPA live migration")

Signed-off-by: Andy Pei <andy.pei at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index 371be23ace..360dd4b034 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -842,6 +842,8 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)
 	vdpa_ifcvf_stop(internal);
 	vdpa_disable_vfio_intr(internal);
 
+	rte_atomic32_set(&internal->running, 0);
+
 	ret = rte_vhost_host_notifier_ctrl(vid, RTE_VHOST_QUEUE_ALL, false);
 	if (ret && ret != -ENOTSUP)
 		goto error;
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 09:36:28.892812648 +0000
+++ 0015-vdpa-ifc-fix-reconnection-in-SW-assisted-live-migrat.patch	2023-02-23 09:36:28.186169203 +0000
@@ -1 +1 @@
-From ef3be7e237dd707f46870b09b93f88f8ee5e75c6 Mon Sep 17 00:00:00 2001
+From eb73764d1146069bb3ffbcfb88e0928ef9c4b525 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ef3be7e237dd707f46870b09b93f88f8ee5e75c6 ]
+
@@ -19 +20,0 @@
-Cc: stable at dpdk.org
@@ -28 +29 @@
-index 9468f66638..35520ea3ae 100644
+index 371be23ace..360dd4b034 100644
@@ -31,2 +32,2 @@
-@@ -1044,6 +1044,8 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)
- 
+@@ -842,6 +842,8 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal)
+ 	vdpa_ifcvf_stop(internal);


More information about the stable mailing list