patch 'vhost: decrease log level for unimplemented requests' has been queued to stable release 20.11.8

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/08a43750b568989f171f8c2bd1caa7ad398da7e9

Thanks.

Luca Boccassi

---
>From 08a43750b568989f171f8c2bd1caa7ad398da7e9 Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Mon, 6 Feb 2023 16:07:33 +0100
Subject: [PATCH] vhost: decrease log level for unimplemented requests

[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]

This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.

Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
---
 lib/librte_vhost/vhost_user.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index da04a37867..93781f4b80 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1679,7 +1679,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
 
 	if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
 		close(msg->fds[0]);
-	VHOST_LOG_CONFIG(INFO, "not implemented\n");
+	VHOST_LOG_CONFIG(DEBUG, "not implemented\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
 }
@@ -2191,7 +2191,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
 		return RTE_VHOST_MSG_RESULT_ERR;
 
 	close(msg->fds[0]);
-	VHOST_LOG_CONFIG(INFO, "not implemented.\n");
+	VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
 }
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 09:36:29.495272824 +0000
+++ 0031-vhost-decrease-log-level-for-unimplemented-requests.patch	2023-02-23 09:36:28.230170013 +0000
@@ -1 +1 @@
-From 43ccd55fdd6ab34b55060045594cc21aefa74383 Mon Sep 17 00:00:00 2001
+From 08a43750b568989f171f8c2bd1caa7ad398da7e9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
- lib/vhost/vhost_user.c | 4 ++--
+ lib/librte_vhost/vhost_user.c | 4 ++--
@@ -22,5 +23,5 @@
-diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
-index 8c1d60b76b..b4236820a2 100644
---- a/lib/vhost/vhost_user.c
-+++ b/lib/vhost/vhost_user.c
-@@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
+diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
+index da04a37867..93781f4b80 100644
+--- a/lib/librte_vhost/vhost_user.c
++++ b/lib/librte_vhost/vhost_user.c
+@@ -1679,7 +1679,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
@@ -28,4 +29,4 @@
- 	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
- 		close(ctx->fds[0]);
--	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
-+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
+ 	if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
+ 		close(msg->fds[0]);
+-	VHOST_LOG_CONFIG(INFO, "not implemented\n");
++	VHOST_LOG_CONFIG(DEBUG, "not implemented\n");
@@ -35 +36 @@
-@@ -2340,7 +2340,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
+@@ -2191,7 +2191,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
@@ -38,3 +39,3 @@
- 	close(ctx->fds[0]);
--	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
-+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
+ 	close(msg->fds[0]);
+-	VHOST_LOG_CONFIG(INFO, "not implemented.\n");
++	VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");