patch 'app/crypto-perf: fix SPI zero' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:04:57 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/b2d5a49ce6f1825f79f12c3cc42f6b18e18595fb

Thanks.

Kevin

---
>From b2d5a49ce6f1825f79f12c3cc42f6b18e18595fb Mon Sep 17 00:00:00 2001
From: Anoob Joseph <anoobj at marvell.com>
Date: Mon, 2 Jan 2023 17:16:54 +0530
Subject: [PATCH] app/crypto-perf: fix SPI zero

[ upstream commit 2218e0780f22519a5be2ef97c80c37798c797857 ]

As per IPsec specification (RFC 4303) SPI zero is reserved. Using
lcore_id directly would mean SPI 0 would also be attempted. This may
lead to failure on an otherwise compliant implementation.

Fixes: 28dde5da503e ("app/crypto-perf: support lookaside IPsec")

Signed-off-by: Anoob Joseph <anoobj at marvell.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
 app/test-crypto-perf/cperf_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
index d975ae1ab8..3b8b97b043 100644
--- a/app/test-crypto-perf/cperf_ops.c
+++ b/app/test-crypto-perf/cperf_ops.c
@@ -691,5 +691,5 @@ create_ipsec_session(struct rte_mempool *sess_mp,
 		.protocol = RTE_SECURITY_PROTOCOL_IPSEC,
 		{.ipsec = {
-			.spi = rte_lcore_id(),
+			.spi = rte_lcore_id() + 1,
 			/**< For testing sake, lcore_id is taken as SPI so that
 			 * for every core a different session is created.
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:24.016772271 +0000
+++ 0006-app-crypto-perf-fix-SPI-zero.patch	2023-02-23 14:46:23.700235722 +0000
@@ -1 +1 @@
-From 2218e0780f22519a5be2ef97c80c37798c797857 Mon Sep 17 00:00:00 2001
+From b2d5a49ce6f1825f79f12c3cc42f6b18e18595fb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2218e0780f22519a5be2ef97c80c37798c797857 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 61a3967697..4a1c9feb1c 100644
+index d975ae1ab8..3b8b97b043 100644
@@ -23 +24 @@
-@@ -723,5 +723,5 @@ create_ipsec_session(struct rte_mempool *sess_mp,
+@@ -691,5 +691,5 @@ create_ipsec_session(struct rte_mempool *sess_mp,



More information about the stable mailing list