patch 'vdpa/ifc: fix argument compatibility check' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:05:14 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/2d551ec8dc3cbfeaa28e4be5f13f159aa98a4b30

Thanks.

Kevin

---
>From 2d551ec8dc3cbfeaa28e4be5f13f159aa98a4b30 Mon Sep 17 00:00:00 2001
From: Andy Pei <andy.pei at intel.com>
Date: Thu, 1 Dec 2022 15:32:20 +0800
Subject: [PATCH] vdpa/ifc: fix argument compatibility check

[ upstream commit 97d2dfc4e15caf654eb84ede24f4c1a43793e850 ]

"sw_fallback_lm=0" means driver does not provide live migration assistance.
so hardware assistance is needed to support live migration.
However registers for live migration in BAR4 are not implemented.
In the case, we just return error after display some logs.

Fixes: 4c3f55cc23ea ("net/ifc: add LM mode parameter")

Signed-off-by: Andy Pei <andy.pei at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 drivers/vdpa/ifc/ifcvf_vdpa.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
index f061d55b06..d3c05bd3f9 100644
--- a/drivers/vdpa/ifc/ifcvf_vdpa.c
+++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
@@ -1260,4 +1260,9 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	}
 	internal->sw_lm = sw_fallback_lm;
+	if (!internal->sw_lm && !internal->hw.lm_cfg) {
+		DRV_LOG(ERR, "Device %s does not support HW assist live migration, please enable sw-live-migration!",
+			pci_dev->name);
+		goto error;
+	}
 
 	internal->vdev = rte_vdpa_register_device(&pci_dev->device, &ifcvf_ops);
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:24.400036685 +0000
+++ 0023-vdpa-ifc-fix-argument-compatibility-check.patch	2023-02-23 14:46:23.730235826 +0000
@@ -1 +1 @@
-From 97d2dfc4e15caf654eb84ede24f4c1a43793e850 Mon Sep 17 00:00:00 2001
+From 2d551ec8dc3cbfeaa28e4be5f13f159aa98a4b30 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 97d2dfc4e15caf654eb84ede24f4c1a43793e850 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 49d68ad1b1..9468f66638 100644
+index f061d55b06..d3c05bd3f9 100644
@@ -24 +25 @@
-@@ -1747,4 +1747,9 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
+@@ -1260,4 +1260,9 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
@@ -33 +34 @@
- 	pthread_mutex_lock(&internal_list_lock);
+ 	internal->vdev = rte_vdpa_register_device(&pci_dev->device, &ifcvf_ops);



More information about the stable mailing list