patch 'vhost: decrease log level for unimplemented requests' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:05:37 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/f05708ea45fc7511b70590df16155574445955a5

Thanks.

Kevin

---
>From f05708ea45fc7511b70590df16155574445955a5 Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Mon, 6 Feb 2023 16:07:33 +0100
Subject: [PATCH] vhost: decrease log level for unimplemented requests

[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]

This patch changes VHOST_USER_SET_VRING_ERR and
VHOST_USER_SET_LOG_FD "not implemented" log levels from
INFO to DEBUG, as implementing these requests is not
mandatory. Having them being displayed at INFO level
may induce some confusion to the end-user.

Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
---
 lib/vhost/vhost_user.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 2b45e35d4a..76c3c27fc1 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -1848,5 +1848,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
 	if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
 		close(msg->fds[0]);
-	VHOST_LOG_CONFIG(INFO, "not implemented\n");
+	VHOST_LOG_CONFIG(DEBUG, "not implemented\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
@@ -2379,5 +2379,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
 
 	close(msg->fds[0]);
-	VHOST_LOG_CONFIG(INFO, "not implemented.\n");
+	VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");
 
 	return RTE_VHOST_MSG_RESULT_OK;
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:24.927731072 +0000
+++ 0046-vhost-decrease-log-level-for-unimplemented-requests.patch	2023-02-23 14:46:23.769235962 +0000
@@ -1 +1 @@
-From 43ccd55fdd6ab34b55060045594cc21aefa74383 Mon Sep 17 00:00:00 2001
+From f05708ea45fc7511b70590df16155574445955a5 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 43ccd55fdd6ab34b55060045594cc21aefa74383 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index 8c1d60b76b..b4236820a2 100644
+index 2b45e35d4a..76c3c27fc1 100644
@@ -26,5 +27,5 @@
-@@ -1819,5 +1819,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
- 	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
- 		close(ctx->fds[0]);
--	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
-+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
+@@ -1848,5 +1848,5 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,
+ 	if (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))
+ 		close(msg->fds[0]);
+-	VHOST_LOG_CONFIG(INFO, "not implemented\n");
++	VHOST_LOG_CONFIG(DEBUG, "not implemented\n");
@@ -33 +34 @@
-@@ -2341,5 +2341,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev,
+@@ -2379,5 +2379,5 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
@@ -35,3 +36,3 @@
- 	close(ctx->fds[0]);
--	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
-+	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
+ 	close(msg->fds[0]);
+-	VHOST_LOG_CONFIG(INFO, "not implemented.\n");
++	VHOST_LOG_CONFIG(DEBUG, "not implemented.\n");



More information about the stable mailing list