patch 'net/hns3: extract common function to query device' has been queued to stable release 21.11.4
Kevin Traynor
ktraynor at redhat.com
Thu Feb 23 16:05:48 CET 2023
Hi,
FYI, your patch has been queued to stable release 21.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable
This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/b6328f7feb6691619bcb474d0e920f4aeec3f9fa
Thanks.
Kevin
---
>From b6328f7feb6691619bcb474d0e920f4aeec3f9fa Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Tue, 31 Jan 2023 21:02:52 +0800
Subject: [PATCH] net/hns3: extract common function to query device
[ upstream commit 52a4e960b49c526dd1ad7c1e91ebcfa664a38e6d ]
Extract common function to query device specifications used by VF and
PF.
Fixes: 9c740336f024 ("net/hns3: get device specifications from firmware")
Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
---
drivers/net/hns3/hns3_common.c | 75 +++++++++++++++++++++++++++++++
drivers/net/hns3/hns3_common.h | 5 ++-
drivers/net/hns3/hns3_ethdev.c | 63 --------------------------
drivers/net/hns3/hns3_ethdev_vf.c | 65 +--------------------------
4 files changed, 81 insertions(+), 127 deletions(-)
diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index 9b6b18a5bc..dc24f7557d 100644
--- a/drivers/net/hns3/hns3_common.c
+++ b/drivers/net/hns3/hns3_common.c
@@ -12,4 +12,5 @@
#include "hns3_regs.h"
#include "hns3_rxtx.h"
+#include "hns3_dcb.h"
int
@@ -769,2 +770,76 @@ hns3_restore_rx_interrupt(struct hns3_hw *hw)
return 0;
}
+
+void
+hns3_set_default_dev_specifications(struct hns3_hw *hw)
+{
+ struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
+
+ hw->max_non_tso_bd_num = HNS3_MAX_NON_TSO_BD_PER_PKT;
+ hw->rss_ind_tbl_size = HNS3_RSS_IND_TBL_SIZE;
+ hw->rss_key_size = HNS3_RSS_KEY_SIZE;
+ hw->intr.int_ql_max = HNS3_INTR_QL_NONE;
+
+ if (hns->is_vf)
+ return;
+
+ hw->max_tm_rate = HNS3_ETHER_MAX_RATE;
+}
+
+static void
+hns3_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)
+{
+ struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
+ struct hns3_dev_specs_0_cmd *req0;
+ struct hns3_dev_specs_1_cmd *req1;
+
+ req0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;
+ req1 = (struct hns3_dev_specs_1_cmd *)desc[1].data;
+
+ hw->max_non_tso_bd_num = req0->max_non_tso_bd_num;
+ hw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);
+ hw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);
+ hw->intr.int_ql_max = rte_le_to_cpu_16(req0->intr_ql_max);
+ hw->min_tx_pkt_len = req1->min_tx_pkt_len;
+
+ if (hns->is_vf)
+ return;
+
+ hw->max_tm_rate = rte_le_to_cpu_32(req0->max_tm_rate);
+}
+
+static int
+hns3_check_dev_specifications(struct hns3_hw *hw)
+{
+ if (hw->rss_ind_tbl_size == 0 ||
+ hw->rss_ind_tbl_size > HNS3_RSS_IND_TBL_SIZE_MAX) {
+ hns3_err(hw, "the indirection table size obtained (%u) is invalid, and should not be zero or exceed the maximum(%u)",
+ hw->rss_ind_tbl_size, HNS3_RSS_IND_TBL_SIZE_MAX);
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+int
+hns3_query_dev_specifications(struct hns3_hw *hw)
+{
+ struct hns3_cmd_desc desc[HNS3_QUERY_DEV_SPECS_BD_NUM];
+ int ret;
+ int i;
+
+ for (i = 0; i < HNS3_QUERY_DEV_SPECS_BD_NUM - 1; i++) {
+ hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS,
+ true);
+ desc[i].flag |= rte_cpu_to_le_16(HNS3_CMD_FLAG_NEXT);
+ }
+ hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS, true);
+
+ ret = hns3_cmd_send(hw, desc, HNS3_QUERY_DEV_SPECS_BD_NUM);
+ if (ret)
+ return ret;
+
+ hns3_parse_dev_specifications(hw, desc);
+
+ return hns3_check_dev_specifications(hw);
+}
diff --git a/drivers/net/hns3/hns3_common.h b/drivers/net/hns3/hns3_common.h
index 0dbb1c0413..1d2ca24194 100644
--- a/drivers/net/hns3/hns3_common.h
+++ b/drivers/net/hns3/hns3_common.h
@@ -59,3 +59,6 @@ void hns3_unmap_rx_interrupt(struct rte_eth_dev *dev);
int hns3_restore_rx_interrupt(struct hns3_hw *hw);
-#endif /* _HNS3_COMMON_H_ */
+void hns3_set_default_dev_specifications(struct hns3_hw *hw);
+int hns3_query_dev_specifications(struct hns3_hw *hw);
+
+#endif /* HNS3_COMMON_H */
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index ca59c42f4a..be6a92a313 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -2665,67 +2665,4 @@ hns3_parse_speed(int speed_cmd, uint32_t *speed)
}
-static void
-hns3_set_default_dev_specifications(struct hns3_hw *hw)
-{
- hw->max_non_tso_bd_num = HNS3_MAX_NON_TSO_BD_PER_PKT;
- hw->rss_ind_tbl_size = HNS3_RSS_IND_TBL_SIZE;
- hw->rss_key_size = HNS3_RSS_KEY_SIZE;
- hw->max_tm_rate = HNS3_ETHER_MAX_RATE;
- hw->intr.int_ql_max = HNS3_INTR_QL_NONE;
-}
-
-static void
-hns3_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)
-{
- struct hns3_dev_specs_0_cmd *req0;
- struct hns3_dev_specs_1_cmd *req1;
-
- req0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;
- req1 = (struct hns3_dev_specs_1_cmd *)desc[1].data;
-
- hw->max_non_tso_bd_num = req0->max_non_tso_bd_num;
- hw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);
- hw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);
- hw->max_tm_rate = rte_le_to_cpu_32(req0->max_tm_rate);
- hw->intr.int_ql_max = rte_le_to_cpu_16(req0->intr_ql_max);
- hw->min_tx_pkt_len = req1->min_tx_pkt_len;
-}
-
-static int
-hns3_check_dev_specifications(struct hns3_hw *hw)
-{
- if (hw->rss_ind_tbl_size == 0 ||
- hw->rss_ind_tbl_size > HNS3_RSS_IND_TBL_SIZE_MAX) {
- hns3_err(hw, "the indirection table size obtained (%u) is invalid, and should not be zero or exceed the maximum(%u)",
- hw->rss_ind_tbl_size, HNS3_RSS_IND_TBL_SIZE_MAX);
- return -EINVAL;
- }
-
- return 0;
-}
-
-static int
-hns3_query_dev_specifications(struct hns3_hw *hw)
-{
- struct hns3_cmd_desc desc[HNS3_QUERY_DEV_SPECS_BD_NUM];
- int ret;
- int i;
-
- for (i = 0; i < HNS3_QUERY_DEV_SPECS_BD_NUM - 1; i++) {
- hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS,
- true);
- desc[i].flag |= rte_cpu_to_le_16(HNS3_CMD_FLAG_NEXT);
- }
- hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS, true);
-
- ret = hns3_cmd_send(hw, desc, HNS3_QUERY_DEV_SPECS_BD_NUM);
- if (ret)
- return ret;
-
- hns3_parse_dev_specifications(hw, desc);
-
- return hns3_check_dev_specifications(hw);
-}
-
static int
hns3_get_capability(struct hns3_hw *hw)
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index 87d094a6b4..0e66a82178 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -689,65 +689,4 @@ hns3vf_interrupt_handler(void *param)
}
-static void
-hns3vf_set_default_dev_specifications(struct hns3_hw *hw)
-{
- hw->max_non_tso_bd_num = HNS3_MAX_NON_TSO_BD_PER_PKT;
- hw->rss_ind_tbl_size = HNS3_RSS_IND_TBL_SIZE;
- hw->rss_key_size = HNS3_RSS_KEY_SIZE;
- hw->intr.int_ql_max = HNS3_INTR_QL_NONE;
-}
-
-static void
-hns3vf_parse_dev_specifications(struct hns3_hw *hw, struct hns3_cmd_desc *desc)
-{
- struct hns3_dev_specs_0_cmd *req0;
- struct hns3_dev_specs_1_cmd *req1;
-
- req0 = (struct hns3_dev_specs_0_cmd *)desc[0].data;
- req1 = (struct hns3_dev_specs_1_cmd *)desc[1].data;
-
- hw->max_non_tso_bd_num = req0->max_non_tso_bd_num;
- hw->rss_ind_tbl_size = rte_le_to_cpu_16(req0->rss_ind_tbl_size);
- hw->rss_key_size = rte_le_to_cpu_16(req0->rss_key_size);
- hw->intr.int_ql_max = rte_le_to_cpu_16(req0->intr_ql_max);
- hw->min_tx_pkt_len = req1->min_tx_pkt_len;
-}
-
-static int
-hns3vf_check_dev_specifications(struct hns3_hw *hw)
-{
- if (hw->rss_ind_tbl_size == 0 ||
- hw->rss_ind_tbl_size > HNS3_RSS_IND_TBL_SIZE_MAX) {
- hns3_err(hw, "the indirection table size obtained (%u) is invalid, and should not be zero or exceed the maximum(%u)",
- hw->rss_ind_tbl_size, HNS3_RSS_IND_TBL_SIZE_MAX);
- return -EINVAL;
- }
-
- return 0;
-}
-
-static int
-hns3vf_query_dev_specifications(struct hns3_hw *hw)
-{
- struct hns3_cmd_desc desc[HNS3_QUERY_DEV_SPECS_BD_NUM];
- int ret;
- int i;
-
- for (i = 0; i < HNS3_QUERY_DEV_SPECS_BD_NUM - 1; i++) {
- hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS,
- true);
- desc[i].flag |= rte_cpu_to_le_16(HNS3_CMD_FLAG_NEXT);
- }
- hns3_cmd_setup_basic_desc(&desc[i], HNS3_OPC_QUERY_DEV_SPECS, true);
-
- ret = hns3_cmd_send(hw, desc, HNS3_QUERY_DEV_SPECS_BD_NUM);
- if (ret)
- return ret;
-
- hns3vf_parse_dev_specifications(hw, desc);
-
- return hns3vf_check_dev_specifications(hw);
-}
-
void
hns3vf_update_push_lsc_cap(struct hns3_hw *hw, bool supported)
@@ -839,5 +778,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
if (revision < PCI_REVISION_ID_HIP09_A) {
- hns3vf_set_default_dev_specifications(hw);
+ hns3_set_default_dev_specifications(hw);
hw->intr.mapping_mode = HNS3_INTR_MAPPING_VEC_RSV_ONE;
hw->intr.gl_unit = HNS3_INTR_COALESCE_GL_UINT_2US;
@@ -850,5 +789,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
}
- ret = hns3vf_query_dev_specifications(hw);
+ ret = hns3_query_dev_specifications(hw);
if (ret) {
PMD_INIT_LOG(ERR,
--
2.39.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-02-23 14:46:25.190492174 +0000
+++ 0057-net-hns3-extract-common-function-to-query-device.patch 2023-02-23 14:46:23.803236081 +0000
@@ -1 +1 @@
-From 52a4e960b49c526dd1ad7c1e91ebcfa664a38e6d Mon Sep 17 00:00:00 2001
+From b6328f7feb6691619bcb474d0e920f4aeec3f9fa Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 52a4e960b49c526dd1ad7c1e91ebcfa664a38e6d ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- drivers/net/hns3/hns3_common.h | 2 +
+ drivers/net/hns3/hns3_common.h | 5 ++-
@@ -19 +20 @@
- 4 files changed, 79 insertions(+), 126 deletions(-)
+ 4 files changed, 81 insertions(+), 127 deletions(-)
@@ -22 +23 @@
-index da0a481f15..74d537d8d0 100644
+index 9b6b18a5bc..dc24f7557d 100644
@@ -25 +26 @@
-@@ -11,4 +11,5 @@
+@@ -12,4 +12,5 @@
@@ -29 +29,0 @@
- #include "hns3_common.h"
@@ -31 +31,2 @@
-@@ -847,2 +848,76 @@ hns3_get_pci_revision_id(struct hns3_hw *hw, uint8_t *revision_id)
+ int
+@@ -769,2 +770,76 @@ hns3_restore_rx_interrupt(struct hns3_hw *hw)
@@ -109 +110 @@
-index 5aa001f0cc..8eaeda26e7 100644
+index 0dbb1c0413..1d2ca24194 100644
@@ -112 +113,2 @@
-@@ -61,4 +61,6 @@ int hns3_restore_rx_interrupt(struct hns3_hw *hw);
+@@ -59,3 +59,6 @@ void hns3_unmap_rx_interrupt(struct rte_eth_dev *dev);
+ int hns3_restore_rx_interrupt(struct hns3_hw *hw);
@@ -114 +116 @@
- int hns3_get_pci_revision_id(struct hns3_hw *hw, uint8_t *revision_id);
+-#endif /* _HNS3_COMMON_H_ */
@@ -117,2 +119,2 @@
-
- #endif /* HNS3_COMMON_H */
++
++#endif /* HNS3_COMMON_H */
@@ -120 +122 @@
-index eb809cd8c9..ab565ce128 100644
+index ca59c42f4a..be6a92a313 100644
@@ -123 +125 @@
-@@ -2648,67 +2648,4 @@ hns3_parse_speed(int speed_cmd, uint32_t *speed)
+@@ -2665,67 +2665,4 @@ hns3_parse_speed(int speed_cmd, uint32_t *speed)
@@ -192 +194 @@
-index e43815607a..d3c1bdf2c5 100644
+index 87d094a6b4..0e66a82178 100644
@@ -261 +263 @@
-@@ -827,5 +766,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
+@@ -839,5 +778,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
@@ -263 +265 @@
- if (hw->revision < PCI_REVISION_ID_HIP09_A) {
+ if (revision < PCI_REVISION_ID_HIP09_A) {
@@ -268 +270 @@
-@@ -838,5 +777,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
+@@ -850,5 +789,5 @@ hns3vf_get_capability(struct hns3_hw *hw)
More information about the stable
mailing list