patch 'net/hns3: remove debug condition for Tx prepare' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Thu Feb 23 16:05:59 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/28/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/483243b873c38cb4a348ceaebad4e322e04761ec

Thanks.

Kevin

---
>From 483243b873c38cb4a348ceaebad4e322e04761ec Mon Sep 17 00:00:00 2001
From: Huisong Li <lihuisong at huawei.com>
Date: Sat, 11 Feb 2023 17:18:27 +0800
Subject: [PATCH] net/hns3: remove debug condition for Tx prepare

[ upstream commit a8d240786e1af129fdf789391d574bf4a7fe60e6 ]

The Tx prepare in driver is always needed if RTE_LIBRTE_ETHDEV_DEBUG
is defined. But it doesn't matter with this macro. Let's remove it.

Fixes: d7ec2c076579 ("net/hns3: select Tx prepare based on Tx offload")

Signed-off-by: Huisong Li <lihuisong at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
---
 drivers/net/hns3/hns3_rxtx.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
index b51d64e4de..5c7de80e7b 100644
--- a/drivers/net/hns3/hns3_rxtx.c
+++ b/drivers/net/hns3/hns3_rxtx.c
@@ -4315,9 +4315,4 @@ static bool
 hns3_get_tx_prep_needed(struct rte_eth_dev *dev)
 {
-#ifdef RTE_LIBRTE_ETHDEV_DEBUG
-	RTE_SET_USED(dev);
-	/* always perform tx_prepare when debug */
-	return true;
-#else
 #define HNS3_DEV_TX_CSKUM_TSO_OFFLOAD_MASK (\
 		RTE_ETH_TX_OFFLOAD_IPV4_CKSUM | \
@@ -4337,5 +4332,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev)
 
 	return false;
-#endif
 }
 
-- 
2.39.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-02-23 14:46:25.448932404 +0000
+++ 0068-net-hns3-remove-debug-condition-for-Tx-prepare.patch	2023-02-23 14:46:23.825236158 +0000
@@ -1 +1 @@
-From a8d240786e1af129fdf789391d574bf4a7fe60e6 Mon Sep 17 00:00:00 2001
+From 483243b873c38cb4a348ceaebad4e322e04761ec Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a8d240786e1af129fdf789391d574bf4a7fe60e6 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 2524f4c3c2..921d72d69d 100644
+index b51d64e4de..5c7de80e7b 100644
@@ -22 +23 @@
-@@ -4312,9 +4312,4 @@ static bool
+@@ -4315,9 +4315,4 @@ static bool
@@ -32 +33 @@
-@@ -4334,5 +4329,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev)
+@@ -4337,5 +4332,4 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev)



More information about the stable mailing list