[PATCH v2] net/i40e: don't check link status on device start

Zhang, Helin helin.zhang at intel.com
Fri Jan 13 14:50:49 CET 2023



> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Friday, January 13, 2023 9:47 PM
> To: Zhang, Helin <helin.zhang at intel.com>
> Cc: Zhang, Yuying <yuying.zhang at intel.com>; Xing, Beilei
> <beilei.xing at intel.com>; Mcnamara, John <john.mcnamara at intel.com>;
> dev at dpdk.org; stable at dpdk.org; Zhang, Qi Z <qi.z.zhang at intel.com>;
> Dapeng Yu <dapengx.yu at intel.com>; Wenxuan Wu
> <wenxuanx.wu at intel.com>
> Subject: Re: [PATCH v2] net/i40e: don't check link status on device start
> 
> On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin <helin.zhang at intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand at redhat.com>
> > > Sent: Friday, January 13, 2023 9:33 PM
> > > To: Zhang, Yuying <yuying.zhang at intel.com>; Xing, Beilei
> > > <beilei.xing at intel.com>; Mcnamara, John <john.mcnamara at intel.com>
> > > Cc: dev at dpdk.org; stable at dpdk.org; Zhang, Qi Z
> > > <qi.z.zhang at intel.com>; Dapeng Yu <dapengx.yu at intel.com>; Wenxuan
> Wu
> > > <wenxuanx.wu at intel.com>
> > > Subject: Re: [PATCH v2] net/i40e: don't check link status on device
> > > start
> > >
> > > Hello i40e maintainers, John,
> > >
> > > On Mon, Jan 9, 2023 at 10:21 AM David Marchand
> > > <david.marchand at redhat.com> wrote:
> > > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand
> > > <david.marchand at redhat.com> wrote:
> > > > > Hi i40e maintainers,
> > > > >
> > > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand
> > > > > <david.marchand at redhat.com> wrote:
> > > > > >
> > > > > > The mentioned changes broke existing applications when the
> > > > > > link status of i40e ports is down at the time the port is started.
> > > > > > Revert those changes, the original issue will need a different fix.
> > Hi David
> >
> > Does it break all the application or just a specific application?
> 
> I don't see how it would not affect all applications seeing how the original
> patch is dumb.
> 
> > We may need to understand the issue you met, and try to fix it later.
> 
> Just unplug the cable or fake a link down on your i40e port, start your
> application or port, then plug the cable back.
> The max frame size will never get applied to hw.
Got it, I will forward to a right expert to check. Thank you very much for reaching out to us!

Regards,
Helin
> 
> 
> --
> David Marchand



More information about the stable mailing list