[PATCH] net/i40e: rework maximum frame size configuration

[David Marchand]

On Fri, Jan 20, 2023 at 2:58 PM Su, Simei <simei.su at intel.com> wrote:
>
> Hi David,
>
> > -----Original Message-----
> > From: David Marchand <david.marchand at redhat.com>
> > Sent: Friday, January 20, 2023 3:34 PM
> > To: Su, Simei <simei.su at intel.com>
> > Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Yuying
> > <yuying.zhang at intel.com>; dev at dpdk.org; Zhang, Qi Z
> > <qi.z.zhang at intel.com>; Yang, Qiming <qiming.yang at intel.com>;
> > stable at dpdk.org; Zhang, Helin <helin.zhang at intel.com>
> > Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration
> >
> > On Mon, Jan 16, 2023 at 1:15 PM Su, Simei <simei.su at intel.com> wrote:
> > >
> > > Hi David,
> > >
> > > > -----Original Message-----
> > > > From: David Marchand <david.marchand at redhat.com>
> > > > Sent: Monday, January 16, 2023 7:19 PM
> > > > To: Su, Simei <simei.su at intel.com>
> > > > Cc: Xing, Beilei <beilei.xing at intel.com>; Zhang, Yuying
> > > > <yuying.zhang at intel.com>; dev at dpdk.org; Zhang, Qi Z
> > > > <qi.z.zhang at intel.com>; Yang, Qiming <qiming.yang at intel.com>;
> > > > stable at dpdk.org; Zhang, Helin <helin.zhang at intel.com>
> > > > Subject: Re: [PATCH] net/i40e: rework maximum frame size
> > > > configuration
> > > >
> > > > On Mon, Jan 16, 2023 at 11:54 AM Simei Su <simei.su at intel.com> wrote:
> > > > >
> > > > > This patch removes unnecessary link status check.
> > > > >
> > > > > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port
> > > > > level")
> > > > > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port
> > > > > level")
> > > > > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722")
> > > > > Cc: stable at dpdk.org
> > > > >
> > > > > Signed-off-by: Simei Su <simei.su at intel.com>
> > > >
> > > > Thanks for looking into the issue.
> > > >
> > > > This is rather close to what I had tried [1] along my original
> > > > report, but it failed in the CI.
> > > > Let's see how the validation of your patch goes.
> > > >
> > > > 1:
> > > >
> > https://patchwork.dpdk.org/project/dpdk/patch/20221212143715.29649-1
> > > > -d
> > > > avid.marchand at redhat.com/
> > > >
> > >
> > > OK. We will find one environment to see why the unit test failed.
> >
> > Any update?
>
> We can reproduce CI error, but "ifconfig interface up" needs to be done firstly
> to reproduce it otherwise this error won't exist. The specific reason hasn't been
> found currently. We will discuss it after Chinese New Year about how to handle it
> more reasonably.

We have regressions in stable releases.
Please put priority when the team is back so that this topic is fixed in 23.03.


Thanks.

-- 
David Marchand