[PATCH] net/nfp: fix teardown of flows sharing a mask ID

Ferruh Yigit ferruh.yigit at amd.com
Thu Jan 26 10:14:06 CET 2023


On 1/24/2023 7:16 AM, Chaoyong He wrote:
> The same data in mask section of different flow add/delete control
> messages will share the same mask ID of mask table.  The first flow
> add control message and the last flow delete control message for a
> specific mask ID should have the NFP_FL_META_FLAG_MANAGE_MASK flag set,
> this will indicate to the flower firmware to allocate/deallocate the
> mask table entry.
> 
> The original logic wrongly process the flow delete control message,
> and caused the first flow delete control message to have the
> NFP_FL_META_FLAG_MANAGE_MASK flagset, thus the flower firmware
> deallocate the mask table entry on the first delete. This in turn
> prevented all the other flows sharing the same mask ID from offloading.
> 
> Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>

Applied to dpdk-next-net/main, thanks.


More information about the stable mailing list