[PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops

Wu, Jingjing jingjing.wu at intel.com
Mon Jul 3 08:53:28 CEST 2023



> -----Original Message-----
> From: Guo, Junfeng <junfeng.guo at intel.com>
> Sent: Wednesday, June 28, 2023 5:12 PM
> To: Wu, Jingjing <jingjing.wu at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; He, Xingguang <xingguang.he at intel.com>; Laatz, Kevin
> <kevin.laatz at intel.com>; Guo, Junfeng <junfeng.guo at intel.com>
> Subject: [PATCH v2] raw/ntb: add check for disabling interrupt in dev close ops
> 
> During EAL cleanup stage, all bus devices are cleaned up properly.
> In the meantime, the ntb example app will also do the device cleanup
> process, which may call the dev ops '*dev->dev_ops->dev_close' twice.
> 
> If this dev ops for ntb was called twice, the interrupt handle for
> EAL will be disabled twice and will lead to error for the seconde
> time. Like this: "EAL: Error disabling MSI-X interrupts for fd xx"
> 
> Thus, this patch added the check process for disabling interrupt in
> dev_close ops, to ensure that interrupt only be disabled once.
> 
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Junfeng Guo <junfeng.guo at intel.com>

Acked-by: Jingjing Wu <jingjing.wu at intel.com>


More information about the stable mailing list