[PATCH v3 1/2] app/testpmd: do not poll stopped queues

Stephen Hemminger stephen at networkplumber.org
Sat Jul 8 03:54:34 CEST 2023


On Wed, 9 Mar 2022 10:36:15 +0000
Dmitry Kozlyuk <dkozlyuk at nvidia.com> wrote:

> > Calling Rx/Tx functions on a stopped queue is not supported.
> > Do not run packet forwarding for streams that use stopped queues.
> > 
> > Each stream has a read-only "disabled" field,
> > so that lcore function can skip such streams.
> > Forwarding engines can set this field
> > using a new "stream_init" callback function
> > by checking relevant queue states,
> > which are stored along with queue configurations
> > (not all PMDs implement rte_eth_rx/tx_queue_info_get()
> > to query the state from there).
> > 
> > Fixes: 5f4ec54f1d16 ("testpmd: queue start and stop")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Dmitry Kozlyuk <dkozlyuk at nvidia.com>
> > Acked-by: Matan Azrad <matan at nvidia.com>
> > ---  
> 
> Pinging testpmd maintainers for this bugfix.
> The sibling ethdev patch will have to wait until the next release cycle.

So you broke a bunch of drivers now that is merged???
Sound like it needs to be reverted. Certainly not something that should
go into stable tree if you expect all drivers to correctly set queue state.


More information about the stable mailing list