patch 'net/mlx5: fix drop action memory leak' has been queued to stable release 21.11.5

Kevin Traynor ktraynor at redhat.com
Fri Jul 21 15:35:03 CEST 2023


Hi,

FYI, your patch has been queued to stable release 21.11.5

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/25/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/bdcd4305c74e0870e8dca0b3928ea4ec5db69023

Thanks.

Kevin

---
>From bdcd4305c74e0870e8dca0b3928ea4ec5db69023 Mon Sep 17 00:00:00 2001
From: Bing Zhao <bingz at nvidia.com>
Date: Thu, 13 Jul 2023 14:19:41 +0300
Subject: [PATCH] net/mlx5: fix drop action memory leak
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 177d90ddd6e0e223966c2fb8a55e036cfb47db7a ]

In DV mode, when quitting an application, the default drop action
and its resources should be released. The Devx action for the TIR
was not destroyed and it would cause 80B memory leak.

With this commit, in DV mode, the action should be destroyed in the
mlx5_devx_drop_action_destroy() explicitly.

Bugzilla ID: 1192
Bugzilla ID: 1255

Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")

Reported-by: David Marchand <david.marchand at redhat.com>
Reported-by: Mário Kuka <kuka at cesnet.cz>
Signed-off-by: Bing Zhao <bingz at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 drivers/net/mlx5/mlx5_devx.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
index 0d5de8303b..b59c5d81bd 100644
--- a/drivers/net/mlx5/mlx5_devx.c
+++ b/drivers/net/mlx5/mlx5_devx.c
@@ -1019,4 +1019,8 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev)
 	struct mlx5_hrxq *hrxq = priv->drop_queue.hrxq;
 
+#if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H)
+	if (hrxq->action != NULL)
+		mlx5_flow_os_destroy_flow_action(hrxq->action);
+#endif
 	if (hrxq->tir != NULL)
 		mlx5_devx_tir_destroy(hrxq);
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-07-21 14:33:59.206826566 +0100
+++ 0008-net-mlx5-fix-drop-action-memory-leak.patch	2023-07-21 14:33:59.016253259 +0100
@@ -1 +1 @@
-From 177d90ddd6e0e223966c2fb8a55e036cfb47db7a Mon Sep 17 00:00:00 2001
+From bdcd4305c74e0870e8dca0b3928ea4ec5db69023 Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 177d90ddd6e0e223966c2fb8a55e036cfb47db7a ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -31 +32 @@
-index d286cfe864..9fa400fc48 100644
+index 0d5de8303b..b59c5d81bd 100644
@@ -34 +35 @@
-@@ -1135,4 +1135,8 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev)
+@@ -1019,4 +1019,8 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev)



More information about the stable mailing list