[PATCH v2] net/nfp: fix set IPv6 flow action can't get right address
Chaoyong He
chaoyong.he at corigine.com
Mon Jun 12 04:24:24 CEST 2023
The former logic of set IPv6 source/destination address flow action
can't get the right IPV6 address, a 32 bit big endian value is
expected while a 8 bit value is provided.
This caused the offloaded packets don't have the right IPv6 address
as expected.
Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action")
Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action")
Cc: stable at dpdk.org
Signed-off-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
---
v2:
* Solve the compile warning about 'strict-aliasing'.
---
drivers/net/nfp/nfp_flow.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c
index 14749f03a2..4ba49a9b49 100644
--- a/drivers/net/nfp/nfp_flow.c
+++ b/drivers/net/nfp/nfp_flow.c
@@ -2164,6 +2164,7 @@ nfp_flow_action_set_ipv6(char *act_data,
bool ip_src_flag)
{
int i;
+ rte_be32_t tmp;
size_t act_size;
struct nfp_fl_act_set_ipv6_addr *set_ip;
const struct rte_flow_action_set_ipv6 *set_ipv6;
@@ -2181,7 +2182,8 @@ nfp_flow_action_set_ipv6(char *act_data,
set_ip->reserved = 0;
for (i = 0; i < 4; i++) {
- set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i * 4];
+ rte_memcpy(&tmp, &set_ipv6->ipv6_addr[i * 4], 4);
+ set_ip->ipv6[i].exact = tmp;
set_ip->ipv6[i].mask = RTE_BE32(0xffffffff);
}
}
--
2.39.1
More information about the stable
mailing list