[PATCH] net/nfp: fix add redundant read configure operations

Ferruh Yigit ferruh.yigit at amd.com
Tue Jun 20 19:53:01 CEST 2023


On 6/14/2023 6:51 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke at corigine.com>
> 
> Performance is reduced because of adding redundant read configure
> operations in nfp_net_parse_ptype() called by nfp_net_recv_pkts(),
> which cause every received packet to spend more time.
> 
> Fix the performance issue by deleting the redundant code directly.
> 
> Fixes: 2e7c36128be ("net/nfp: report packet type by Rx descriptor")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Qin Ke <qin.ke at corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund at corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang at corigine.com>

Applied to dpdk-next-net/main, thanks.

<...>

> diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
> index 9867db4388..297864450b 100644
> --- a/drivers/net/nfp/nfp_rxtx.c
> +++ b/drivers/net/nfp/nfp_rxtx.c
> @@ -317,7 +317,8 @@ nfp_net_parse_meta(struct nfp_net_rx_desc *rxds,
>   *   Mbuf to set the packet type.
>   */
>  static void
> -nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, struct rte_mbuf *mb)
> +nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype,
> +		struct rte_mbuf *mb)

Above unrelated modification dropped while merging.


More information about the stable mailing list