patch 'net: fix return type of IPv4 L4 packet checksum' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Sun Jun 25 08:33:39 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=403d133d7f5a64347b7f79d69ce6d432a7673ea3

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 403d133d7f5a64347b7f79d69ce6d432a7673ea3 Mon Sep 17 00:00:00 2001
From: Elena Agostini <eagostini at nvidia.com>
Date: Thu, 6 Apr 2023 09:49:44 +0000
Subject: [PATCH] net: fix return type of IPv4 L4 packet checksum
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 3b3fef9de22af80d173453ab65a80b01ce38cbfd ]

Function returns 0 or -1 but the return type is uint16_t.

Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments")

Signed-off-by: Elena Agostini <eagostini at nvidia.com>
---
 lib/net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h
index 9c8e8206f0..0cafb980ef 100644
--- a/lib/net/rte_ip.h
+++ b/lib/net/rte_ip.h
@@ -514,7 +514,7 @@ rte_ipv4_udptcp_cksum_verify(const struct rte_ipv4_hdr *ipv4_hdr,
  *   Return 0 if the checksum is correct, else -1.
  */
 __rte_experimental
-static inline uint16_t
+static inline int
 rte_ipv4_udptcp_cksum_mbuf_verify(const struct rte_mbuf *m,
 				  const struct rte_ipv4_hdr *ipv4_hdr,
 				  uint16_t l4_off)
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-06-25 14:31:58.638496000 +0800
+++ 0001-net-fix-return-type-of-IPv4-L4-packet-checksum.patch	2023-06-25 14:31:58.285773900 +0800
@@ -1 +1 @@
-From 3b3fef9de22af80d173453ab65a80b01ce38cbfd Mon Sep 17 00:00:00 2001
+From 403d133d7f5a64347b7f79d69ce6d432a7673ea3 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 3b3fef9de22af80d173453ab65a80b01ce38cbfd ]
@@ -9 +11,0 @@
-Cc: stable at dpdk.org
@@ -17 +19 @@
-index a310e9d498..e7106256aa 100644
+index 9c8e8206f0..0cafb980ef 100644


More information about the stable mailing list