patch 'kernel/freebsd: fix function parameter list' has been queued to stable release 22.11.3
Xueming Li
xuemingl at nvidia.com
Sun Jun 25 08:33:45 CEST 2023
Hi,
FYI, your patch has been queued to stable release 22.11.3
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/23. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging
This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=f14b25d9250403c24d0c46a97a38df6f5c5b1fb8
Thanks.
Xueming Li <xuemingl at nvidia.com>
---
>From f14b25d9250403c24d0c46a97a38df6f5c5b1fb8 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Mon, 22 May 2023 10:22:41 +0100
Subject: [PATCH] kernel/freebsd: fix function parameter list
Cc: Xueming Li <xuemingl at nvidia.com>
[ upstream commit 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c ]
Functions which take no parameters should explicitly have "(void)" as
the parameter list, rather than "()".
Reported upstream on FreeBSD ports collection [1].
[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
Fixes: 764bf26873b9 ("add FreeBSD support")
Reported-by: John Baldwin <jhb at freebsd.org>
Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
---
kernel/freebsd/contigmem/contigmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c
index bd72f4d620..7dd87599d9 100644
--- a/kernel/freebsd/contigmem/contigmem.c
+++ b/kernel/freebsd/contigmem/contigmem.c
@@ -111,7 +111,7 @@ static struct cdevsw contigmem_ops = {
};
static int
-contigmem_load()
+contigmem_load(void)
{
char index_string[8], description[32];
int i, error = 0;
@@ -178,7 +178,7 @@ error:
}
static int
-contigmem_unload()
+contigmem_unload(void)
{
int i;
--
2.25.1
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2023-06-25 14:31:58.784411700 +0800
+++ 0007-kernel-freebsd-fix-function-parameter-list.patch 2023-06-25 14:31:58.285773900 +0800
@@ -1 +1 @@
-From 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c Mon Sep 17 00:00:00 2001
+From f14b25d9250403c24d0c46a97a38df6f5c5b1fb8 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 12b7ef3c4a6262e1c0f747bd0037a3a8df38ab4c ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
More information about the stable
mailing list