patch 'vhost: fix notification stats for packed ring' has been queued to stable release 22.11.3

Xueming Li xuemingl at nvidia.com
Sun Jun 25 08:35:00 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/27/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=fe3e1fc9d84fc9bbdab45e64fe8150cc3b0dfb17

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From fe3e1fc9d84fc9bbdab45e64fe8150cc3b0dfb17 Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Thu, 25 May 2023 18:25:24 +0200
Subject: [PATCH] vhost: fix notification stats for packed ring
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 5e8e1166dfc5613566a73299f7cc1bf6510e81c2 ]

Guest notification counter was only incremented for split
ring, this patch adds it also for packed ring.

Fixes: 1ea74efd7fa4 ("vhost: add statistics for guest notification")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
---
 lib/vhost/vhost.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 0fd6f4bbf4..e125c3d615 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -952,6 +952,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)
 kick:
 	if (kick) {
 		eventfd_write(vq->callfd, (eventfd_t)1);
+		if (dev->flags & VIRTIO_DEV_STATS_ENABLED)
+			vq->stats.guest_notifications++;
 		if (dev->notify_ops->guest_notified)
 			dev->notify_ops->guest_notified(dev->vid);
 	}
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-06-25 14:32:00.697406000 +0800
+++ 0082-vhost-fix-notification-stats-for-packed-ring.patch	2023-06-25 14:31:58.455773900 +0800
@@ -1 +1 @@
-From 5e8e1166dfc5613566a73299f7cc1bf6510e81c2 Mon Sep 17 00:00:00 2001
+From fe3e1fc9d84fc9bbdab45e64fe8150cc3b0dfb17 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 5e8e1166dfc5613566a73299f7cc1bf6510e81c2 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index 8fdab13c70..8554ab4002 100644
+index 0fd6f4bbf4..e125c3d615 100644
@@ -22 +24 @@
-@@ -973,6 +973,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)
+@@ -952,6 +952,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq)


More information about the stable mailing list