[PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling
Tal Shnaiderman
talshn at nvidia.com
Sun Mar 12 18:18:09 CET 2023
> Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling
>
> External email: Use caution opening links or attachments
>
>
> 19/02/2023 18:53, Stephen Hemminger:
> > On Fri, 3 Feb 2023 11:14:06 -0800
> > Stephen Hemminger <stephen at networkplumber.org> wrote:
> >
> > > This patchset keeps uncovering bad practices in the cmdline library
> > > around end of file and signal handling.
> > >
> > > Stephen Hemminger (3):
> > > cmdline: make rdline status not private
> > > cmdline: handle EOF in cmdline_poll
> > > testpmd: cleanup cleanly from signal
> > >
> > > app/test-pmd/cmdline.c | 29 +++++--------
> > > app/test-pmd/testpmd.c | 77 ++++++++++++++++-------------------
> > > app/test-pmd/testpmd.h | 1 +
> > > lib/cmdline/cmdline.c | 11 +++--
> > > lib/cmdline/cmdline.h | 6 +++
> > > lib/cmdline/cmdline_private.h | 6 ---
> > > 6 files changed, 62 insertions(+), 68 deletions(-)
> > >
> >
> > Could this please be merged for 23.03?
> > There are Ack's.
> > The only CI failure is a bogus performance test failure.
>
> There was no review from testpmd maintainers.
>
> I've added Cc: stable at dpdk.org.
> Applied, thanks.
>
Hi,
Commit "testpmd: cleanup cleanly from signal" from this series breaks TestPMD's interactive mode on Windows.
See https://bugs.dpdk.org/show_bug.cgi?id=1180
More information about the stable
mailing list