patch 'event/cnxk: fix SSO cleanup' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 15 15:35:57 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/349431b3fb2a6f027036913019396c3286fe104c

Thanks.

Kevin

---
>From 349431b3fb2a6f027036913019396c3286fe104c Mon Sep 17 00:00:00 2001
From: Volodymyr Fialko <vfialko at marvell.com>
Date: Thu, 2 Mar 2023 11:58:32 +0100
Subject: [PATCH] event/cnxk: fix SSO cleanup

[ upstream commit c31a3b37bb26c2f7f270592c8976072b510869dd ]

dev_fini() can return EAGAIN in case if LF is active(used by other
devices). Ignoring return code leads to early free of resources that are
still in use.

Fixes: 8558dcaa05b8 ("event/cnxk: add build infra and device setup")

Signed-off-by: Volodymyr Fialko <vfialko at marvell.com>
---
 drivers/event/cnxk/cnxk_eventdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/drivers/event/cnxk/cnxk_eventdev.c
index 46a788ef4e..d543fdd14e 100644
--- a/drivers/event/cnxk/cnxk_eventdev.c
+++ b/drivers/event/cnxk/cnxk_eventdev.c
@@ -637,7 +637,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)
 	cnxk_tim_fini();
 	roc_sso_rsrc_fini(&dev->sso);
-	roc_sso_dev_fini(&dev->sso);
 
-	return 0;
+	return roc_sso_dev_fini(&dev->sso);
 }
 
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:20.713247972 +0000
+++ 0004-event-cnxk-fix-SSO-cleanup.patch	2023-03-15 14:30:20.537123532 +0000
@@ -1 +1 @@
-From c31a3b37bb26c2f7f270592c8976072b510869dd Mon Sep 17 00:00:00 2001
+From 349431b3fb2a6f027036913019396c3286fe104c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c31a3b37bb26c2f7f270592c8976072b510869dd ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 5f1fa1e96d..cb9ba5d353 100644
+index 46a788ef4e..d543fdd14e 100644
@@ -22 +23 @@
-@@ -671,7 +671,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)
+@@ -637,7 +637,6 @@ cnxk_sso_fini(struct rte_eventdev *event_dev)



More information about the stable mailing list