patch 'compress/mlx5: fix output Adler-32 checksum offset' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 15 15:36:05 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/38c2a798fd1546e0ecba038730a38c1d08042974

Thanks.

Kevin

---
>From 38c2a798fd1546e0ecba038730a38c1d08042974 Mon Sep 17 00:00:00 2001
From: Michael Baum <michaelba at nvidia.com>
Date: Tue, 21 Feb 2023 09:07:50 +0200
Subject: [PATCH] compress/mlx5: fix output Adler-32 checksum offset

[ upstream commit d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 ]

After de/compress dequeue, the output checksum is copied into the op
structure. The "output_checksum" field in op structure is "uint64_t"
type, and the 32-bit checksums (CRC32, Adler-32) are copied into the
lower 32 bits.

When both CRC32 and Adler-32 are configured, CRC32 is copied into the
lower 32 bits and Adler-32 into the upper 32 bits.
However, in mlx5 PMD Adler-32 without CRC, is mistakenly copied into the
upper 32 bits.

This patch updates Adler-32 output checksum to be copied into the
lower 32 bits.

Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions")

Signed-off-by: Michael Baum <michaelba at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
---
 drivers/compress/mlx5/mlx5_compress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c
index 8d92ed492e..76ad3de1f5 100644
--- a/drivers/compress/mlx5/mlx5_compress.c
+++ b/drivers/compress/mlx5/mlx5_compress.c
@@ -635,5 +635,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops,
 			case RTE_COMP_CHECKSUM_ADLER32:
 				op->output_chksum = (uint64_t)rte_be_to_cpu_32
-					    (opaq[idx].adler32) << 32;
+						    (opaq[idx].adler32);
 				break;
 			case RTE_COMP_CHECKSUM_CRC32_ADLER32:
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:20.907413203 +0000
+++ 0012-compress-mlx5-fix-output-Adler-32-checksum-offset.patch	2023-03-15 14:30:20.564123626 +0000
@@ -1 +1 @@
-From d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 Mon Sep 17 00:00:00 2001
+From 38c2a798fd1546e0ecba038730a38c1d08042974 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit d54dd89f49ded1e2d8d0e83710b2347a5de4d7f5 ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
-index 06d1ff5b95..82088a7b8c 100644
+index 8d92ed492e..76ad3de1f5 100644
@@ -32 +33 @@
-@@ -634,5 +634,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops,
+@@ -635,5 +635,5 @@ mlx5_compress_dequeue_burst(void *queue_pair, struct rte_comp_op **ops,



More information about the stable mailing list