patch 'ethdev: remove telemetry Rx mbuf alloc failed field' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 15 15:36:12 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/096166c31c4a21b43ef32e93fb32278593194a42

Thanks.

Kevin

---
>From 096166c31c4a21b43ef32e93fb32278593194a42 Mon Sep 17 00:00:00 2001
From: Ferruh Yigit <ferruh.yigit at amd.com>
Date: Tue, 28 Feb 2023 18:02:30 +0000
Subject: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field

[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ]

'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
which is exposed via ehtdev stat APIs.

But telemetry exposes this field to user via "/ethdev/info",
instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".

Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs

Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")

Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
Acked-by: Thomas Monjalon <thomas at monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 lib/ethdev/rte_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 0320694f82..3796cc02f6 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6371,6 +6371,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
 	rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min",
 			eth_dev->data->min_rx_buf_size);
-	rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",
-			eth_dev->data->rx_mbuf_alloc_failed);
 	rte_ether_format_addr(mac_addr, sizeof(mac_addr),
 			eth_dev->data->mac_addrs);
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:21.068130603 +0000
+++ 0019-ethdev-remove-telemetry-Rx-mbuf-alloc-failed-field.patch	2023-03-15 14:30:20.575123665 +0000
@@ -1 +1 @@
-From 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 Mon Sep 17 00:00:00 2001
+From 096166c31c4a21b43ef32e93fb32278593194a42 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6686b2d2a0b68698d7bddf51d5a9861fb8a4eaf3 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -26 +27 @@
-index 3814c202cd..3d137523a6 100644
+index 0320694f82..3796cc02f6 100644
@@ -29,2 +30,2 @@
-@@ -6643,6 +6643,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
- 	rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min",
+@@ -6371,6 +6371,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
+ 	rte_tel_data_add_dict_u64(d, "rx_mbuf_size_min",
@@ -32 +33 @@
--	rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
+-	rte_tel_data_add_dict_u64(d, "rx_mbuf_alloc_fail",



More information about the stable mailing list