patch 'net/hns3: fix empty devargs parsing' has been queued to stable release 21.11.4

Kevin Traynor ktraynor at redhat.com
Wed Mar 15 15:36:20 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/1b619068f32964344ed2e3a94956ec64afd97fb7

Thanks.

Kevin

---
>From 1b619068f32964344ed2e3a94956ec64afd97fb7 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 2 Mar 2023 07:50:09 +0000
Subject: [PATCH] net/hns3: fix empty devargs parsing

[ upstream commit 8e9bd29995ddb1205d90291a684bcf71599d6623 ]

The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'
(e.g. rx_func_hint).

Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function")
Fixes: 70791213242e ("net/hns3: support masking device capability")
Fixes: 2fc3e696a7f1 ("net/hns3: add runtime config for mailbox limit time")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: Dongdong Liu <liudongdong3 at huawei.com>
---
 drivers/net/hns3/hns3_common.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index dc24f7557d..2532c3b770 100644
--- a/drivers/net/hns3/hns3_common.c
+++ b/drivers/net/hns3/hns3_common.c
@@ -162,4 +162,7 @@ hns3_parse_io_hint_func(const char *key, const char *value, void *extra_args)
 	RTE_SET_USED(key);
 
+	if (value == NULL || extra_args == NULL)
+		return 0;
+
 	if (strcmp(value, "vec") == 0)
 		hint = HNS3_IO_FUNC_HINT_VEC;
@@ -202,4 +205,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args)
 	RTE_SET_USED(key);
 
+	if (value == NULL || extra_args == NULL)
+		return 0;
+
 	val = strtoull(value, NULL, HNS3_CONVERT_TO_HEXADECIMAL);
 	*(uint64_t *)extra_args = val;
@@ -215,4 +221,7 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args)
 	RTE_SET_USED(key);
 
+	if (value == NULL || extra_args == NULL)
+		return 0;
+
 	val = strtoul(value, NULL, HNS3_CONVERT_TO_DECIMAL);
 
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:21.257280322 +0000
+++ 0027-net-hns3-fix-empty-devargs-parsing.patch	2023-03-15 14:30:20.589123714 +0000
@@ -1 +1 @@
-From 8e9bd29995ddb1205d90291a684bcf71599d6623 Mon Sep 17 00:00:00 2001
+From 1b619068f32964344ed2e3a94956ec64afd97fb7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8e9bd29995ddb1205d90291a684bcf71599d6623 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index a0c9e66c2c..f077ef5057 100644
+index dc24f7557d..2532c3b770 100644
@@ -28 +29 @@
-@@ -164,4 +164,7 @@ hns3_parse_io_hint_func(const char *key, const char *value, void *extra_args)
+@@ -162,4 +162,7 @@ hns3_parse_io_hint_func(const char *key, const char *value, void *extra_args)
@@ -36 +37 @@
-@@ -204,4 +207,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args)
+@@ -202,4 +205,7 @@ hns3_parse_dev_caps_mask(const char *key, const char *value, void *extra_args)
@@ -44 +45 @@
-@@ -217,4 +223,7 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args)
+@@ -215,4 +221,7 @@ hns3_parse_mbx_time_limit(const char *key, const char *value, void *extra_args)



More information about the stable mailing list