patch 'dma/skeleton: fix empty devargs parsing' has been queued to stable release 21.11.4

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/20/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c6dd06ddb62c2b1f6731fa73a764cbf11cf43264

Thanks.

Kevin

---
>From c6dd06ddb62c2b1f6731fa73a764cbf11cf43264 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 2 Mar 2023 07:50:11 +0000
Subject: [PATCH] dma/skeleton: fix empty devargs parsing

[ upstream commit e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 ]

The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'
(e.g. lcore).

Fixes: 05d5fc66a269 ("dma/skeleton: introduce skeleton driver")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
---
 drivers/dma/skeleton/skeleton_dmadev.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/skeleton/skeleton_dmadev.c b/drivers/dma/skeleton/skeleton_dmadev.c
index 6b0bb14e2c..08bf20e899 100644
--- a/drivers/dma/skeleton/skeleton_dmadev.c
+++ b/drivers/dma/skeleton/skeleton_dmadev.c
@@ -512,7 +512,13 @@ skeldma_parse_lcore(const char *key __rte_unused,
 		    void *opaque)
 {
-	int lcore_id = atoi(value);
+	int lcore_id;
+
+	if (value == NULL || opaque == NULL)
+		return -EINVAL;
+
+	lcore_id = atoi(value);
 	if (lcore_id >= 0 && lcore_id < RTE_MAX_LCORE)
 		*(int *)opaque = lcore_id;
+
 	return 0;
 }
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 14:30:21.303767738 +0000
+++ 0029-dma-skeleton-fix-empty-devargs-parsing.patch	2023-03-15 14:30:20.594123731 +0000
@@ -1 +1 @@
-From e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 Mon Sep 17 00:00:00 2001
+From c6dd06ddb62c2b1f6731fa73a764cbf11cf43264 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e0e5dd0450db22fc7712da4b5a8e6fd6e081c870 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 9b6da655fd..daf35eccce 100644
+index 6b0bb14e2c..08bf20e899 100644
@@ -25 +26 @@
-@@ -516,7 +516,13 @@ skeldma_parse_lcore(const char *key __rte_unused,
+@@ -512,7 +512,13 @@ skeldma_parse_lcore(const char *key __rte_unused,