patch 'raw/skeleton: fix empty devargs parsing' has been queued to stable release 20.11.8

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Mar 15 23:46:11 CET 2023


Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/17/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/bbedd033a8eb0c80f184b54507610decf179c52f

Thanks.

Luca Boccassi

---
>From bbedd033a8eb0c80f184b54507610decf179c52f Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 2 Mar 2023 07:50:12 +0000
Subject: [PATCH] raw/skeleton: fix empty devargs parsing

[ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ]

The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.

This patch fixes segment fault when parse input args with 'only keys'
(e.g. self_test).

Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
---
 drivers/raw/skeleton/skeleton_rawdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c
index aa3beaad18..ebb9075dd9 100644
--- a/drivers/raw/skeleton/skeleton_rawdev.c
+++ b/drivers/raw/skeleton/skeleton_rawdev.c
@@ -659,6 +659,8 @@ skeldev_get_selftest(const char *key __rte_unused,
 		     void *opaque)
 {
 	int *flag = opaque;
+	if (value == NULL || opaque == NULL)
+		return -EINVAL;
 	*flag = atoi(value);
 	return 0;
 }
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-15 22:44:50.783085494 +0000
+++ 0020-raw-skeleton-fix-empty-devargs-parsing.patch	2023-03-15 22:44:49.579850177 +0000
@@ -1 +1 @@
-From 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 Mon Sep 17 00:00:00 2001
+From bbedd033a8eb0c80f184b54507610decf179c52f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 11da6149224a8de53d2ddd2aacba7b158cc4e3b4 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index b2ca1cc5cd..53fe49f936 100644
+index aa3beaad18..ebb9075dd9 100644
@@ -25 +26 @@
-@@ -664,6 +664,8 @@ skeldev_get_selftest(const char *key __rte_unused,
+@@ -659,6 +659,8 @@ skeldev_get_selftest(const char *key __rte_unused,


More information about the stable mailing list