[PATCH] test/crypto: fix errors for test stats testcase

Saoirse O'Donovan saoirse.odonovan at intel.com
Mon Mar 20 10:29:56 CET 2023


The test stats testcase was printing the same error message for
multiple errors in the test stats testcase. This is now replaced
with descriptive error messages, which match the cause of the failure.

Fixes: 202d375 ("app/test: add cryptodev unit and performance tests")
Cc: stable at dpdk.org
Cc: declan.doherty at intel.com

Signed-off-by: Saoirse O'Donovan <saoirse.odonovan at intel.com>
---
 .mailmap                  |  1 +
 app/test/test_cryptodev.c | 12 ++++++------
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/.mailmap b/.mailmap
index 4018f0fc47..f61972b63d 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1175,6 +1175,7 @@ Sangjin Han <sangjin at eecs.berkeley.edu>
 Sankar Chokkalingam <sankarx.chokkalingam at intel.com>
 Santoshkumar Karanappa Rastapur <santosh.rastapur at broadcom.com>
 Santosh Shukla <santosh.shukla at caviumnetworks.com> <sshukla at mvista.com>
+Saoirse O'Donovan <saoirse.odonovan at intel.com>
 Saori Usami <susami at igel.co.jp>
 Sarath Somasekharan <sarathx.somasekharan at intel.com>
 Sarosh Arif <sarosh.arif at emumba.com>
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index af3d89b9c7..59cf3ec40f 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -12335,11 +12335,11 @@ test_stats(void)
 	TEST_ASSERT((stats.enqueued_count == 1),
 		"rte_cryptodev_stats_get returned unexpected enqueued stat");
 	TEST_ASSERT((stats.dequeued_count == 1),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected dequeued stat");
 	TEST_ASSERT((stats.enqueue_err_count == 0),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected enqueued error count stat");
 	TEST_ASSERT((stats.dequeue_err_count == 0),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected dequeued error count stat");
 
 	/* invalid device but should ignore and not reset device stats*/
 	rte_cryptodev_stats_reset(ts_params->valid_devs[0] + 300);
@@ -12347,7 +12347,7 @@ test_stats(void)
 			&stats),
 		"rte_cryptodev_stats_get failed");
 	TEST_ASSERT((stats.enqueued_count == 1),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected enqueued stat after invalid reset");
 
 	/* check that a valid reset clears stats */
 	rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
@@ -12355,9 +12355,9 @@ test_stats(void)
 			&stats),
 					  "rte_cryptodev_stats_get failed");
 	TEST_ASSERT((stats.enqueued_count == 0),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected enqueued stat after valid reset");
 	TEST_ASSERT((stats.dequeued_count == 0),
-		"rte_cryptodev_stats_get returned unexpected enqueued stat");
+		"rte_cryptodev_stats_get returned unexpected dequeued stat after valid reset");
 
 	return TEST_SUCCESS;
 }
-- 
2.25.1



More information about the stable mailing list