patch 'examples/qos_sched: fix config entries in wrong sections' has been queued to stable release 20.11.8

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Mar 29 03:04:37 CEST 2023


Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/31/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/e3779bd6049db332b5a9b9b58b6ad54a49a03ff0

Thanks.

Luca Boccassi

---
>From e3779bd6049db332b5a9b9b58b6ad54a49a03ff0 Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Tue, 21 Mar 2023 13:13:49 +0000
Subject: [PATCH] examples/qos_sched: fix config entries in wrong sections

[ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ]

When specifying the QoS config, the profiles to be used for each pipe
within a subport must be specified in the subport section, not in the
section for the subport profile itself. Similarly for subport profiles,
those should be specified in the port section.

Fixes: de3cfa2c9823 ("sched: initial import")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 examples/qos_sched/profile.cfg    | 4 ++--
 examples/qos_sched/profile_ov.cfg | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg
index a308d61f02..f1769e49bb 100644
--- a/examples/qos_sched/profile.cfg
+++ b/examples/qos_sched/profile.cfg
@@ -26,6 +26,8 @@ number of subports per port = 1
 number of pipes per subport = 4096
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
+
 [subport profile 0]
 tb rate = 1250000000           ; Bytes per second
 tb size = 1000000              ; Bytes
@@ -46,8 +48,6 @@ tc 12 rate = 1250000000        ; Bytes per second
 
 tc period = 10                 ; Milliseconds
 
-pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 305175               ; Bytes per second
diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg
index 14c89ae340..b6fe21ee1e 100644
--- a/examples/qos_sched/profile_ov.cfg
+++ b/examples/qos_sched/profile_ov.cfg
@@ -6,12 +6,14 @@
 frame overhead = 24
 number of subports per port = 1
 
+subport 0-8 = 0
+
 ; Subport configuration
 [subport 0]
 number of pipes per subport = 32
 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
 
-subport 0-8 = 0
+pipe 0-31 = 0               ; These pipes are configured with pipe profile 0
 
 [subport profile 0]
 tb rate = 8400000           ; Bytes per second
@@ -32,8 +34,6 @@ tc 11 rate = 8400000         ; Bytes per second
 tc 12 rate = 8400000         ; Bytes per second
 tc period = 10              ; Milliseconds
 
-pipe 0-31 = 0               ; These pipes are configured with pipe profile 0
-
 ; Pipe configuration
 [pipe profile 0]
 tb rate = 16800000             ; Bytes per second
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-29 01:31:22.559787373 +0100
+++ 0001-examples-qos_sched-fix-config-entries-in-wrong-secti.patch	2023-03-29 01:31:22.466039159 +0100
@@ -1 +1 @@
-From 86dfed2a8ed704e013f054985a92d46f07ff48d1 Mon Sep 17 00:00:00 2001
+From e3779bd6049db332b5a9b9b58b6ad54a49a03ff0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 86dfed2a8ed704e013f054985a92d46f07ff48d1 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -17,5 +18,3 @@
- examples/qos_sched/profile.cfg     | 6 +++---
- examples/qos_sched/profile_ov.cfg  | 6 +++---
- examples/qos_sched/profile_pie.cfg | 6 +++---
- examples/qos_sched/profile_red.cfg | 6 +++---
- 4 files changed, 12 insertions(+), 12 deletions(-)
+ examples/qos_sched/profile.cfg    | 4 ++--
+ examples/qos_sched/profile_ov.cfg | 6 +++---
+ 2 files changed, 5 insertions(+), 5 deletions(-)
@@ -24 +23 @@
-index e8de101b6c..00d4c7c1a5 100644
+index a308d61f02..f1769e49bb 100644
@@ -45,7 +43,0 @@
-@@ -71,4 +71,4 @@ tc period = 40                ; Milliseconds
- 
- tc 12 oversubscription weight = 1
- 
--tc 12 wrr weights = 1 1 1 1
-\ No newline at end of file
-+tc 12 wrr weights = 1 1 1 1
@@ -81,58 +72,0 @@
-diff --git a/examples/qos_sched/profile_pie.cfg b/examples/qos_sched/profile_pie.cfg
-index 241f748b33..bbc09d912b 100644
---- a/examples/qos_sched/profile_pie.cfg
-+++ b/examples/qos_sched/profile_pie.cfg
-@@ -21,12 +21,14 @@
- frame overhead = 24
- number of subports per port = 1
- 
-+subport 0-8 = 0                ; These subports are configured with subport profile 0
-+
- ; Subport configuration
- [subport 0]
- number of pipes per subport = 4096
- queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
- 
--subport 0-8 = 0                ; These subports are configured with subport profile 0
-+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
- 
- [subport profile 0]
- tb rate = 1250000000           ; Bytes per second
-@@ -48,8 +50,6 @@ tc 12 rate = 1250000000        ; Bytes per second
- 
- tc period = 10                 ; Milliseconds
- 
--pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
--
- ; Pipe configuration
- [pipe profile 0]
- tb rate = 305175               ; Bytes per second
-diff --git a/examples/qos_sched/profile_red.cfg b/examples/qos_sched/profile_red.cfg
-index 4486d2799e..cee1470fd7 100644
---- a/examples/qos_sched/profile_red.cfg
-+++ b/examples/qos_sched/profile_red.cfg
-@@ -21,12 +21,14 @@
- frame overhead = 24
- number of subports per port = 1
- 
-+subport 0-8 = 0                ; These subports are configured with subport profile 0
-+
- ; Subport configuration
- [subport 0]
- number of pipes per subport = 4096
- queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64
- 
--subport 0-8 = 0                ; These subports are configured with subport profile 0
-+pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
- 
- [subport profile 0]
- tb rate = 1250000000           ; Bytes per second
-@@ -48,8 +50,6 @@ tc 12 rate = 1250000000        ; Bytes per second
- 
- tc period = 10                 ; Milliseconds
- 
--pipe 0-4095 = 0                ; These pipes are configured with pipe profile 0
--
- ; Pipe configuration
- [pipe profile 0]
- tb rate = 305175               ; Bytes per second


More information about the stable mailing list