patch 'acl: fix crash on PPC64 with GCC 11' has been queued to stable release 20.11.8

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 20.11.8

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 03/31/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/01561c4dfd3ce08b058f4b42a45db1da4349381b

Thanks.

Luca Boccassi

---
>From 01561c4dfd3ce08b058f4b42a45db1da4349381b Mon Sep 17 00:00:00 2001
From: David Christensen <drc at linux.vnet.ibm.com>
Date: Wed, 22 Mar 2023 13:29:33 -0400
Subject: [PATCH] acl: fix crash on PPC64 with GCC 11

[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ]

Original ACL implementation of Altivec optimized code included an
explicit -O2 optimization level for a particular inlined function.
When DPDK is built with the default -O3 optimization level on gcc
11.x or later, the resulting code may generate a segmentation
fault as observed in acl_autotest.

Since there is no explicit reason given for the local function
optimization level in the original commit, and testing with gcc
versions 8.x through 12.x results in working code at all -O
optimization settings, the local optimization is removed.

Bugzilla ID: 1197

Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
Tested-by: Thinh Tran <thinhtr at linux.vnet.ibm.com>
---
 lib/librte_acl/acl_run_altivec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_acl/acl_run_altivec.h b/lib/librte_acl/acl_run_altivec.h
index 24a41eec17..317a036c84 100644
--- a/lib/librte_acl/acl_run_altivec.h
+++ b/lib/librte_acl/acl_run_altivec.h
@@ -102,7 +102,7 @@ acl_match_check_x4(int slot, const struct rte_acl_ctx *ctx, struct parms *parms,
 /*
  * Process 4 transitions (in 2 XMM registers) in parallel
  */
-static inline __attribute__((optimize("O2"))) xmm_t
+static __rte_always_inline xmm_t
 transition4(xmm_t next_input, const uint64_t *trans,
 	xmm_t *indices1, xmm_t *indices2)
 {
-- 
2.39.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-03-29 01:31:22.959200805 +0100
+++ 0008-acl-fix-crash-on-PPC64-with-GCC-11.patch	2023-03-29 01:31:22.506039977 +0100
@@ -1 +1 @@
-From 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 Mon Sep 17 00:00:00 2001
+From 01561c4dfd3ce08b058f4b42a45db1da4349381b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3f62bba2e7aa15e5f1e418cdced0f4160de154b3 ]
+
@@ -18 +19,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
- lib/acl/acl_run_altivec.h | 2 +-
+ lib/librte_acl/acl_run_altivec.h | 2 +-
@@ -26,4 +27,4 @@
-diff --git a/lib/acl/acl_run_altivec.h b/lib/acl/acl_run_altivec.h
-index 4dfe7a14b4..4556e1503b 100644
---- a/lib/acl/acl_run_altivec.h
-+++ b/lib/acl/acl_run_altivec.h
+diff --git a/lib/librte_acl/acl_run_altivec.h b/lib/librte_acl/acl_run_altivec.h
+index 24a41eec17..317a036c84 100644
+--- a/lib/librte_acl/acl_run_altivec.h
++++ b/lib/librte_acl/acl_run_altivec.h