[dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe

wangyunjian wangyunjian at huawei.com
Wed May 24 09:11:30 CEST 2023


> -----Original Message-----
> From: David Marchand [mailto:david.marchand at redhat.com]
> Sent: Thursday, January 5, 2023 4:34 PM
> To: wangyunjian <wangyunjian at huawei.com>; Thomas Monjalon
> <thomas at monjalon.net>
> Cc: dev at dpdk.org; qi.z.zhang at intel.com; anatoly.burakov at intel.com;
> Huangshaozhang <huangshaozhang at huawei.com>; stable at dpdk.org;
> lianglipei <lianglipei at huawei.com>
> Subject: Re: [dpdk-dev] [PATCH 1/1] eal: fix error log in rte_dev_probe
> 
> Hi Yunjian, Thomas,
> 
> On Mon, Dec 5, 2022 at 9:02 AM Yunjian Wang <wangyunjian at huawei.com>
> wrote:
> >
> > In the device probing, there is no need to log the error message in
> > the case, that device has been already probed and return with -EEXIST.
> >
> > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Lipei Liang <lianglipei at huawei.com>
> > Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> 
> It seems it is a partial fix and a duplicate work for:
> https://patchwork.dpdk.org/project/dpdk/patch/20190302024253.15594-3-tho
> mas at monjalon.net/

I agree with Thomas's patch. Can we consider merging this patch first?
Because this err log can easily mislead problem troubleshooting.

> 
> This patch is part of a series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=3612
> I see no activity on it, but there were some comments.
> 
> Thomas, do you intend to work on this series of yours?
> 
> 
> --
> David Marchand



More information about the stable mailing list