patch 'net/ngbe: check process type in close operation' has been queued to stable release 21.11.6

Kevin Traynor ktraynor at redhat.com
Thu Nov 2 14:11:30 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/08/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/4cdc254d17bff073607d9d201531567020e388b6

Thanks.

Kevin

---
>From 4cdc254d17bff073607d9d201531567020e388b6 Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Thu, 28 Sep 2023 17:47:57 +0800
Subject: [PATCH] net/ngbe: check process type in close operation

[ upstream commit bf86fb0b7dd723421ea35826c0163c34b09d1c69 ]

The secondary processes are not allowed to release shared resources.
Only process-private resources should be freed in a secondary process.
Most of the time, there is no process-private resource,
so the close operation is just forbidden in a secondary process.

Fixes: cc63194e89cb ("net/ngbe: support close and reset device")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/ngbe/ngbe_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
index c6e37150e2..3038694042 100644
--- a/drivers/net/ngbe/ngbe_ethdev.c
+++ b/drivers/net/ngbe/ngbe_ethdev.c
@@ -1218,4 +1218,7 @@ ngbe_dev_close(struct rte_eth_dev *dev)
 	PMD_INIT_FUNC_TRACE();
 
+	if (rte_eal_process_type() != RTE_PROC_PRIMARY)
+		return 0;
+
 	ngbe_pf_reset_hw(hw);
 
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-02 13:09:41.465243946 +0000
+++ 0024-net-ngbe-check-process-type-in-close-operation.patch	2023-11-02 13:09:40.808163319 +0000
@@ -1 +1 @@
-From bf86fb0b7dd723421ea35826c0163c34b09d1c69 Mon Sep 17 00:00:00 2001
+From 4cdc254d17bff073607d9d201531567020e388b6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit bf86fb0b7dd723421ea35826c0163c34b09d1c69 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 1cdd56497e..478da014b2 100644
+index c6e37150e2..3038694042 100644
@@ -23 +24 @@
-@@ -1263,4 +1263,7 @@ ngbe_dev_close(struct rte_eth_dev *dev)
+@@ -1218,4 +1218,7 @@ ngbe_dev_close(struct rte_eth_dev *dev)



More information about the stable mailing list