patch 'net/ngbe: keep link down after device close' has been queued to stable release 21.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/08/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/5658f2dd846746d6fd5ff567a8abfd5da41079c2

Thanks.

Kevin

---
>From 5658f2dd846746d6fd5ff567a8abfd5da41079c2 Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Thu, 28 Sep 2023 17:47:55 +0800
Subject: [PATCH] net/ngbe: keep link down after device close

[ upstream commit 3dd64cf80ed5142eeb0a8e3051a583fb38761221 ]

When the port is closed, hardware is reset to power on. And
ngbe_dev_stop() is just returned 0 to avoid secondary calls,
so that the link led remains on. Fix this bug by adding to turn
off the PHY power.

Fixes: 3518df5774c7 ("net/ngbe: support device start/stop")
Fixes: 708ebe7d0399 ("net/ngbe: fix external PHY power down")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/ngbe/ngbe_ethdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c
index 6ec15b60de..c6e37150e2 100644
--- a/drivers/net/ngbe/ngbe_ethdev.c
+++ b/drivers/net/ngbe/ngbe_ethdev.c
@@ -1146,5 +1146,5 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
 
 	if (hw->adapter_stopped)
-		return 0;
+		goto out;
 
 	PMD_INIT_FUNC_TRACE();
@@ -1197,4 +1197,8 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
 	dev->data->dev_started = 0;
 
+out:
+	/* close phy to prevent reset in dev_close from restarting physical link */
+	hw->phy.set_phy_power(hw, false);
+
 	return 0;
 }
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-02 13:09:41.418444165 +0000
+++ 0022-net-ngbe-keep-link-down-after-device-close.patch	2023-11-02 13:09:40.805163310 +0000
@@ -1 +1 @@
-From 3dd64cf80ed5142eeb0a8e3051a583fb38761221 Mon Sep 17 00:00:00 2001
+From 5658f2dd846746d6fd5ff567a8abfd5da41079c2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3dd64cf80ed5142eeb0a8e3051a583fb38761221 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -17,2 +18,2 @@
- drivers/net/ngbe/ngbe_ethdev.c | 8 +++++---
- 1 file changed, 5 insertions(+), 3 deletions(-)
+ drivers/net/ngbe/ngbe_ethdev.c | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
@@ -21 +22 @@
-index dd387779ab..1cdd56497e 100644
+index 6ec15b60de..c6e37150e2 100644
@@ -24 +25 @@
-@@ -1168,5 +1168,5 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
+@@ -1146,5 +1146,5 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
@@ -31,8 +32 @@
-@@ -1190,6 +1190,4 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
- 		vfinfo[vf].clear_to_send = false;
- 
--	hw->phy.set_phy_power(hw, false);
--
- 	ngbe_dev_clear_queues(dev);
- 
-@@ -1218,4 +1216,8 @@ ngbe_dev_stop(struct rte_eth_dev *dev)
+@@ -1197,4 +1197,8 @@ ngbe_dev_stop(struct rte_eth_dev *dev)