[PATCH] net/sfc: fix null dereference in syslog
Weiguo Li
liwg06 at foxmail.com
Sat Nov 4 08:37:15 CET 2023
When ctx->sa is null, sfc_err(ctx->sa, ...) will triger a null
dereference in the macro of sfc_err. Use SFC_GENERIC_LOG(ERR, ...)
to avoid that.
Fixes: 44db08d53be3 ("net/sfc: maintain controller to EFX interface mapping")
Cc: stable at dpdk.org
Signed-off-by: Weiguo Li <liweiguo at xencore.cn>
---
drivers/net/sfc/sfc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 1efe64a36a..6d57b2ba26 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -2070,7 +2070,7 @@ sfc_process_mport_journal_cb(void *data, efx_mport_desc_t *mport,
struct sfc_mport_journal_ctx *ctx = data;
if (ctx == NULL || ctx->sa == NULL) {
- sfc_err(ctx->sa, "received NULL context or SFC adapter");
+ SFC_GENERIC_LOG(ERR, "received NULL context or SFC adapter");
return EINVAL;
}
--
2.34.1
More information about the stable
mailing list