[PATCH 1/2] pipeline: fix calloc parameters

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Mon Nov 6 15:26:10 CET 2023



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at amd.com>
> Sent: Thursday, November 2, 2023 1:09 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>; R, Kamalakannan
> <kamalakannan.r at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org
> Subject: [PATCH 1/2] pipeline: fix calloc parameters
> 
> gcc [1] generates warning [2] about calloc usage, because calloc
> parameter order is wrong, fixing it by replacing parameters.
> 
> [1]
> gcc (GCC) 14.0.0 20231102 (experimental)
> 
> [2]
>  Compiling C object .../pipeline_rte_swx_pipeline_spec.c.o
> .../rte_swx_pipeline_spec.c: In function ‘pipeline_spec_parse’:
> ../lib/pipeline/rte_swx_pipeline_spec.c:2893:11:
>   warning: allocation of insufficient size ‘1’ for type
>            ‘struct pipeline_spec’ with size ‘144’ [-Walloc-size]
>  2893 |         s = calloc(sizeof(struct pipeline_spec), 1);
>       |           ^
> 
> .../rte_swx_pipeline_spec.c: In function ‘pipeline_iospec_parse’:
> ../lib/pipeline/rte_swx_pipeline_spec.c:4244:11:
>   warning: allocation of insufficient size ‘1’ for type
>            ‘struct pipeline_iospec’ with size ‘64’ [-Walloc-size]
>  4244 |         s = calloc(sizeof(struct pipeline_iospec), 1);
>       |           ^
> 
> Fixes: 30c4abb90942 ("pipeline: rework specification file-based pipeline
> build")
> Fixes: 54cae37ef4ef ("pipeline: support I/O specification")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at amd.com>
> ---
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>



More information about the stable mailing list