[PATCH] net/iavf: fix error devargs parsing

Mingjin Ye mingjinx.ye at intel.com
Mon Nov 13 11:44:36 CET 2023


This patch fixes an unknown parsing result without
devarg "no-poll-on-link-down".

Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down")
Cc: stable at dpdk.org

Signed-off-by: Mingjin Ye <mingjinx.ye at intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 0c6ab4ac5a..d1edb0dd5c 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
 	struct rte_kvargs *kvlist;
 	int ret;
 	int watchdog_period = -1;
-	uint16_t no_poll_on_link_down;
 
 	if (!devargs)
 		return 0;
@@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev)
 		ad->devargs.watchdog_period = watchdog_period;
 
 	ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG,
-				 &parse_u16, &no_poll_on_link_down);
+				 &parse_bool, &ad->devargs.no_poll_on_link_down);
 	if (ret)
 		goto bail;
-	if (no_poll_on_link_down == 0)
-		ad->devargs.no_poll_on_link_down = 0;
-	else
-		ad->devargs.no_poll_on_link_down = 1;
 
 	if (ad->devargs.quanta_size != 0 &&
 	    (ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||
-- 
2.25.1



More information about the stable mailing list