patch 'app/procinfo: fix RSS info' has been queued to stable release 21.11.6

[Kevin Traynor]

Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/21/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/ff10f5d05bc2abad53a6adc6f70802e1ad34c3c4

Thanks.

Kevin

---
>From ff10f5d05bc2abad53a6adc6f70802e1ad34c3c4 Mon Sep 17 00:00:00 2001
From: Jie Hai <haijie1 at huawei.com>
Date: Thu, 2 Nov 2023 16:20:16 +0800
Subject: [PATCH] app/procinfo: fix RSS info

[ upstream commit 33079eccf5c1a99af722fe168d8465f602bc98b2 ]

Command show-port should show RSS info (rss_key, len and rss_hf),
However, the information is shown only when rss_conf.rss_key is not
NULL. Since no memory is allocated for rss_conf.rss_key, rss_key
will always be NULL and the rss_info will never show. This patch
fixes it.

Fixes: 8a37f37fc243 ("app/procinfo: add --show-port")

Signed-off-by: Jie Hai <haijie1 at huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3 at huawei.com>
Acked-by: Reshma Pattan <reshma.pattan at intel.com>
Acked-by: Chengwen Feng <fengchengwen at huawei.com>
Acked-by: Huisong Li <lihuisong at huawei.com>
---
 app/proc-info/main.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index f628377c19..41f983d52b 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -101,4 +101,6 @@ static uint32_t enable_dump_regs;
 static char *dump_regs_file_prefix;
 
+#define RSS_HASH_KEY_SIZE 64
+
 /**< display usage */
 static void
@@ -724,4 +726,5 @@ show_port(void)
 		struct rte_ether_addr mac;
 		struct rte_eth_dev_owner owner;
+		uint8_t rss_key[RSS_HASH_KEY_SIZE];
 
 		/* Skip if port is not in mask */
@@ -867,15 +870,15 @@ show_port(void)
 		}
 
+		rss_conf.rss_key = rss_key;
+		rss_conf.rss_key_len = dev_info.hash_key_size;
 		ret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);
 		if (ret == 0) {
-			if (rss_conf.rss_key) {
-				printf("  - RSS\n");
-				printf("\t  -- RSS len %u key (hex):",
-						rss_conf.rss_key_len);
-				for (k = 0; k < rss_conf.rss_key_len; k++)
-					printf(" %x", rss_conf.rss_key[k]);
-				printf("\t  -- hf 0x%"PRIx64"\n",
-						rss_conf.rss_hf);
-			}
+			printf("  - RSS\n");
+			printf("\t  -- RSS len %u key (hex):",
+					rss_conf.rss_key_len);
+			for (k = 0; k < rss_conf.rss_key_len; k++)
+				printf(" %x", rss_conf.rss_key[k]);
+			printf("\t  -- hf 0x%"PRIx64"\n",
+					rss_conf.rss_hf);
 		}
 
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-16 13:21:53.226358994 +0000
+++ 0028-app-procinfo-fix-RSS-info.patch	2023-11-16 13:21:52.456946392 +0000
@@ -1 +1 @@
-From 33079eccf5c1a99af722fe168d8465f602bc98b2 Mon Sep 17 00:00:00 2001
+From ff10f5d05bc2abad53a6adc6f70802e1ad34c3c4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 33079eccf5c1a99af722fe168d8465f602bc98b2 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index ce53bc30df..3a441ba075 100644
+index f628377c19..41f983d52b 100644
@@ -28,2 +29,2 @@
-@@ -152,4 +152,6 @@ static struct desc_param rx_desc_param;
- static struct desc_param tx_desc_param;
+@@ -101,4 +101,6 @@ static uint32_t enable_dump_regs;
+ static char *dump_regs_file_prefix;
@@ -33 +34 @@
- /* display usage */
+ /**< display usage */
@@ -35 +36 @@
-@@ -1012,4 +1014,5 @@ show_port(void)
+@@ -724,4 +726,5 @@ show_port(void)
@@ -41 +42 @@
-@@ -1170,15 +1173,15 @@ show_port(void)
+@@ -867,15 +870,15 @@ show_port(void)