patch 'ethdev: account for smaller MTU when setting default' has been queued to stable release 21.11.6

Kevin Traynor ktraynor at redhat.com
Thu Nov 16 14:23:35 CET 2023


Hi,

FYI, your patch has been queued to stable release 21.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/21/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/4308ee164213562432477a26eddc98d03ce98dcf

Thanks.

Kevin

---
>From 4308ee164213562432477a26eddc98d03ce98dcf Mon Sep 17 00:00:00 2001
From: Joshua Washington <joshwash at google.com>
Date: Tue, 7 Nov 2023 22:05:34 -0800
Subject: [PATCH] ethdev: account for smaller MTU when setting default

[ upstream commit da266c6556d22b470679484b62e3f9db192e4032 ]

Currently, if not specified in the user configuration,
rte_eth_dev_configure() sets the MTU of the device to RTE_EHTER_MTU.

This value could potentially be larger than the MTU that the device
supports. This change updates the configured MTU to be the minimum of
the maximum supported MTU and the default DPDK MTU.

Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")

Signed-off-by: Joshua Washington <joshwash at google.com>
Signed-off-by: Rushil Gupta <rushilg at google.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 lib/ethdev/rte_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 081d8bb297..9a8dd94e0a 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -1529,5 +1529,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
 
 	if (dev_conf->rxmode.mtu == 0)
-		dev->data->dev_conf.rxmode.mtu = RTE_ETHER_MTU;
+		dev->data->dev_conf.rxmode.mtu =
+			(dev_info.max_mtu == 0) ? RTE_ETHER_MTU :
+			RTE_MIN(dev_info.max_mtu, RTE_ETHER_MTU);
 
 	ret = eth_dev_validate_mtu(port_id, &dev_info,
-- 
2.41.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-11-16 13:21:53.808754317 +0000
+++ 0053-ethdev-account-for-smaller-MTU-when-setting-default.patch	2023-11-16 13:21:52.531946611 +0000
@@ -1 +1 @@
-From da266c6556d22b470679484b62e3f9db192e4032 Mon Sep 17 00:00:00 2001
+From 4308ee164213562432477a26eddc98d03ce98dcf Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit da266c6556d22b470679484b62e3f9db192e4032 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 9163ef47ea..3858983fcc 100644
+index 081d8bb297..9a8dd94e0a 100644
@@ -28 +29 @@
-@@ -1420,5 +1420,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,
+@@ -1529,5 +1529,7 @@ rte_eth_dev_configure(uint16_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q,



More information about the stable mailing list