[PATCH] dma/skeleton: fix pthread set affinity

Thomas Monjalon thomas at monjalon.net
Tue Oct 17 10:59:08 CEST 2023


15/08/2023 14:21, David Marchand:
> On Mon, Aug 14, 2023 at 6:24 PM Tyler Retzlaff
> <roretzla at linux.microsoft.com> wrote:
> >
> > On Sat, Aug 12, 2023 at 07:27:38AM +0530, Vipin Varghese wrote:
> > > In skeleton dma driver, the user can pin the dma thread to desired
> > > cpu core. The previous commit changed the api from set-affinity to
> > > get-affinity leading to thread to be pinned to first available lcore.
> > >
> > > Bugzilla ID: 1270
> > > Fixes: 7fdf30d8b259 ("eal/windows: remove most pthread lifetime shim functions")
> 
> This Fixes: looks wrong.
> 
> I would blame (and blame the bad reviewers):
> Fixes: f241553b43ee ("dma/skeleton: drop some pthread API calls")
> 
> Can you double check?

I agree with the root cause pointed by David.

Applied, thanks.





More information about the stable mailing list