[PATCH] ice: Increase L1 check interval to account for lengthier link time

Timothy Miskell timothy.miskell at intel.com
Thu Oct 19 18:38:46 CEST 2023


For edge cases where the transceiver is physically inserted first and immediately afterwards the DPDK PF is started the LSC event may occur outside the current setting for the maximum check interval window. This change lengthens the check interval to account for this along with other reported cases where the link event be longer than 1 second.

Cc: stable at dpdk.org

Reported-by: Timothy Miskell
Suggested-by: Timothy Miskell
Signed-off-by: Timothy Miskell
Reviewed-by: Larry Wang
Tested-by: Jonathan Tsai
---
 .mailmap                     | 2 ++
 drivers/net/ice/ice_ethdev.c | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..93c09a23ee 100644
--- a/.mailmap
+++ b/.mailmap
@@ -674,6 +674,7 @@ John Romein <romein at astron.nl>
 John W. Linville <linville at tuxdriver.com>
 Jonas Pfefferle <jpf at zurich.ibm.com> <pepperjo at japf.ch>
 Jonathan Erb <jonathan.erb at threatblockr.com> <jonathan.erb at banduracyber.com>
+Jonathan Tsai <jonathan1.tsai at intel.com>
 Jon DeVree <nuxi at vault24.org>
 Jon Loeliger <jdl at netgate.com>
 Joongi Kim <joongi at an.kaist.ac.kr>
@@ -1414,6 +1415,7 @@ Tianli Lai <laitianli at tom.com>
 Tianyu Li <tianyu.li at arm.com>
 Timmons C. Player <timmons.player at spirent.com>
 Timothy McDaniel <timothy.mcdaniel at intel.com>
+Timothy Miskell <timothy.miskell at intel.com>
 Timothy Redaelli <tredaelli at redhat.com>
 Tim Shearer <tim.shearer at overturenetworks.com>
 Ting Xu <ting.xu at intel.com>
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 305077e74e..6ef06b9926 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -3992,8 +3992,8 @@ ice_atomic_write_link_status(struct rte_eth_dev *dev,
 static int
 ice_link_update(struct rte_eth_dev *dev, int wait_to_complete)
 {
-#define CHECK_INTERVAL 100  /* 100ms */
-#define MAX_REPEAT_TIME 10  /* 1s (10 * 100ms) in total */
+#define CHECK_INTERVAL 50  /* 50ms */
+#define MAX_REPEAT_TIME 40  /* 2s (40 * 50ms) in total */
 	struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 	struct ice_link_status link_status;
 	struct rte_eth_link link, old;
-- 
2.25.1



More information about the stable mailing list