patch 'net/sfc: fix Rx and Tx queue state' has been queued to stable release 22.11.4

Xueming Li xuemingl at nvidia.com
Sun Oct 22 16:22:41 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/15/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=8ab4f361b051feeea2db87e1c9b09f65f5d05718

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 8ab4f361b051feeea2db87e1c9b09f65f5d05718 Mon Sep 17 00:00:00 2001
From: Jie Hai <haijie1 at huawei.com>
Date: Fri, 8 Sep 2023 19:28:55 +0800
Subject: [PATCH] net/sfc: fix Rx and Tx queue state
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 ]

The DPDK framework reports the queue state, which is stored in
dev->data->tx_queue_state and dev->data->rx_queue_state. The
state is maintained by the driver. Users may determine whether
a queue participates in packet forwarding based on the state.
Therefore, the driver needs to modify the queue state in time
according to the actual situation.

Fixes: 9ad9ff476cac ("ethdev: add queue state in queried queue information")

Signed-off-by: Jie Hai <haijie1 at huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit at amd.com>
---
 drivers/net/sfc/sfc_repr.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c
index b3a41167fb..79025e9052 100644
--- a/drivers/net/sfc/sfc_repr.c
+++ b/drivers/net/sfc/sfc_repr.c
@@ -291,6 +291,7 @@ static int
 sfc_repr_dev_start(struct rte_eth_dev *dev)
 {
 	struct sfc_repr *sr = sfc_repr_by_eth_dev(dev);
+	uint16_t i;
 	int ret;

 	sfcr_info(sr, "entry");
@@ -302,6 +303,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev)
 	if (ret != 0)
 		goto fail_start;

+	for (i = 0; i < dev->data->nb_rx_queues; i++)
+		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+	for (i = 0; i < dev->data->nb_tx_queues; i++)
+		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+
 	sfcr_info(sr, "done");

 	return 0;
@@ -366,6 +372,7 @@ static int
 sfc_repr_dev_stop(struct rte_eth_dev *dev)
 {
 	struct sfc_repr *sr = sfc_repr_by_eth_dev(dev);
+	uint16_t i;
 	int ret;

 	sfcr_info(sr, "entry");
@@ -380,6 +387,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev)

 	sfc_repr_unlock(sr);

+	for (i = 0; i < dev->data->nb_rx_queues; i++)
+		dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+	for (i = 0; i < dev->data->nb_tx_queues; i++)
+		dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+
 	sfcr_info(sr, "done");

 	return 0;
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-10-22 22:17:39.087972900 +0800
+++ 0132-net-sfc-fix-Rx-and-Tx-queue-state.patch	2023-10-22 22:17:34.416723700 +0800
@@ -1 +1 @@
-From 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 Mon Sep 17 00:00:00 2001
+From 8ab4f361b051feeea2db87e1c9b09f65f5d05718 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 35ac4f275f37d6002ed62e78342af96b9cf7e1e7 ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 5f93192522..c2e5d4eb9e 100644
+index b3a41167fb..79025e9052 100644
@@ -26 +28 @@
-@@ -263,6 +263,7 @@ static int
+@@ -291,6 +291,7 @@ static int
@@ -34 +36 @@
-@@ -274,6 +275,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev)
+@@ -302,6 +303,11 @@ sfc_repr_dev_start(struct rte_eth_dev *dev)
@@ -46 +48 @@
-@@ -338,6 +344,7 @@ static int
+@@ -366,6 +372,7 @@ static int
@@ -54 +56 @@
-@@ -352,6 +359,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev)
+@@ -380,6 +387,11 @@ sfc_repr_dev_stop(struct rte_eth_dev *dev)


More information about the stable mailing list