patch 'ethdev: add check in async flow action query' has been queued to stable release 22.11.4

Xueming Li xuemingl at nvidia.com
Sun Oct 22 16:22:49 CEST 2023


Hi,

FYI, your patch has been queued to stable release 22.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/15/23. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://git.dpdk.org/dpdk-stable/log/?h=22.11-staging

This queued commit can be viewed at:
https://git.dpdk.org/dpdk-stable/commit/?h=22.11-staging&id=c20753f52ff8f3485f60595827ed24abd00a7c66

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From c20753f52ff8f3485f60595827ed24abd00a7c66 Mon Sep 17 00:00:00 2001
From: Suanming Mou <suanmingm at nvidia.com>
Date: Tue, 17 Oct 2023 16:23:17 +0800
Subject: [PATCH] ethdev: add check in async flow action query
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit a5ea57ac0d29a56400315a2acc7c58799b564367 ]

This commit adds the ops check to fix the coverity issue.

Coverity issue: 403258
Fixes: c9dc03840873 ("ethdev: add indirect action async query")

Signed-off-by: Suanming Mou <suanmingm at nvidia.com>
Acked-by: Ori Kam <orika at nvidia.com>
---
 lib/ethdev/rte_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index 1a67a987f5..2eadb0a032 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -1887,6 +1887,8 @@ rte_flow_async_action_handle_query(uint16_t port_id,
 	const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error);
 	int ret;

+	if (unlikely(!ops))
+		return -rte_errno;
 	ret = ops->async_action_handle_query(dev, queue_id, op_attr,
 					  action_handle, data, user_data, error);
 	return flow_err(port_id, ret, error);
--
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2023-10-22 22:17:39.351782600 +0800
+++ 0140-ethdev-add-check-in-async-flow-action-query.patch	2023-10-22 22:17:34.436723700 +0800
@@ -1 +1 @@
-From a5ea57ac0d29a56400315a2acc7c58799b564367 Mon Sep 17 00:00:00 2001
+From c20753f52ff8f3485f60595827ed24abd00a7c66 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit a5ea57ac0d29a56400315a2acc7c58799b564367 ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index 874f845513..3a67f1aaba 100644
+index 1a67a987f5..2eadb0a032 100644
@@ -22 +24 @@
-@@ -2226,6 +2226,8 @@ rte_flow_async_action_handle_query(uint16_t port_id,
+@@ -1887,6 +1887,8 @@ rte_flow_async_action_handle_query(uint16_t port_id,
@@ -30 +32 @@
- 	ret = flow_err(port_id, ret, error);
+ 	return flow_err(port_id, ret, error);


More information about the stable mailing list