[PATCH] net/nfp: fix offload flags of the security capabilities

Chaoyong He chaoyong.he at corigine.com
Sat Oct 28 08:31:40 CEST 2023


From: Shihong Wang <shihong.wang at corigine.com>

This patch resolves configuration error of ol_flags in the
rte_security_capability. Currently ol_flags in the ingress direction
of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact,
ol_flags only in the egress direction of the SA needs to be configured.

Fixes: e6d69ea011c9 ("net/nfp: get security capabilities and session size")
Cc: stable at dpdk.org

Signed-off-by: Shihong Wang <shihong.wang at corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he at corigine.com>
Reviewed-by: Peng Zhang <peng.zhang at corigine.com>
---
 drivers/net/nfp/nfp_ipsec.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c
index a76ba2a91d..302962c58b 100644
--- a/drivers/net/nfp/nfp_ipsec.c
+++ b/drivers/net/nfp/nfp_ipsec.c
@@ -242,7 +242,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps
+		.crypto_capabilities = nfp_crypto_caps,
+		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 	},
 	{ /* IPsec Inline Crypto Tunnel Ingress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -257,8 +258,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps,
-		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+		.crypto_capabilities = nfp_crypto_caps
 	},
 	{ /* IPsec Inline Crypto Transport Egress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -273,7 +273,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps
+		.crypto_capabilities = nfp_crypto_caps,
+		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 	},
 	{ /* IPsec Inline Crypto Transport Ingress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO,
@@ -288,8 +289,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps,
-		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+		.crypto_capabilities = nfp_crypto_caps
 	},
 	{ /* IPsec Inline Protocol Tunnel Egress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -304,7 +304,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps
+		.crypto_capabilities = nfp_crypto_caps,
+		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 	},
 	{ /* IPsec Inline Protocol Tunnel Ingress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -319,8 +320,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps,
-		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+		.crypto_capabilities = nfp_crypto_caps
 	},
 	{ /* IPsec Inline Protocol Transport Egress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -335,7 +335,8 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps
+		.crypto_capabilities = nfp_crypto_caps,
+		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
 	},
 	{ /* IPsec Inline Protocol Transport Ingress */
 		.action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL,
@@ -350,8 +351,7 @@ static const struct rte_security_capability nfp_security_caps[] = {
 				.esn = 1
 				}
 		},
-		.crypto_capabilities = nfp_crypto_caps,
-		.ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA
+		.crypto_capabilities = nfp_crypto_caps
 	},
 	{
 		.action = RTE_SECURITY_ACTION_TYPE_NONE
-- 
2.39.1



More information about the stable mailing list