[PATCH] net/mlx5: fix the workspace double free in Windows

Raslan Darawsheh rasland at nvidia.com
Tue Oct 31 09:05:05 CET 2023


Hi,

> -----Original Message-----
> From: Bing Zhao <bingz at nvidia.com>
> Sent: Thursday, October 26, 2023 12:15 PM
> To: Matan Azrad <matan at nvidia.com>; Slava Ovsiienko
> <viacheslavo at nvidia.com>; Raslan Darawsheh <rasland at nvidia.com>;
> Suanming Mou <suanmingm at nvidia.com>; Ori Kam <orika at nvidia.com>
> Cc: dev at dpdk.org; Gregory Etelson <getelson at nvidia.com>;
> stable at dpdk.org
> Subject: [PATCH] net/mlx5: fix the workspace double free in Windows
> 
> The thread specific variable workspace indicated by "key_workspace"
> should be freed explicitly when closing a device. For example, in
> Linux, when exiting an application, the thread will not exit
> explicitly and the thread resources will not be deconstructed.
> 
> The commit to solve this introduced a global list to manage the
> workspace resources as a garbage collector. It will also be executed
> in Windows, but the workspaces have already been freed in the
> function mlx5_flow_os_release_workspace().
> 
> With this commit, the garbage collector will only be executed in
> Linux. The workspace resources management in Windows will remain
> the same with some stub function when needed.
> 
> Fixes: dc7c5e0aa905 ("net/mlx5: fix flow workspace destruction")
> Cc: getelson at nvidia.com
> Cc: stable at dpdk.org
> 
> Signed-off-by: Bing Zhao <bingz at nvidia.com>
> Acked-by: Matan Azrad <matan at nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh


More information about the stable mailing list