[PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop

Zhang, Qi Z qi.z.zhang at intel.com
Mon Sep 4 04:30:49 CEST 2023



> -----Original Message-----
> From: Lu, Wenzhuo <wenzhuo.lu at intel.com>
> Sent: Monday, September 4, 2023 10:18 AM
> To: Richardson, Bruce <bruce.richardson at intel.com>; dev at dpdk.org
> Cc: Wu, Jingjing <jingjing.wu at intel.com>; stable at dpdk.org
> Subject: RE: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop
> 
> 
> 
> > -----Original Message-----
> > From: Richardson, Bruce <bruce.richardson at intel.com>
> > Sent: Thursday, August 31, 2023 8:34 PM
> > To: dev at dpdk.org
> > Cc: Richardson, Bruce <bruce.richardson at intel.com>; Lu, Wenzhuo
> > <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>;
> > stable at dpdk.org
> > Subject: [PATCH v2 2/4] net/iavf: fix buffer leak on Tx queue stop
> >
> > When a queue is stopped all buffers are meant to released from it, and
> > then a new set of buffers reallocated on start. For the iavf code when
> > using vector Tx, some buffers were left in the ring, and so those
> > buffers were leaked. The buffers were missed as the release code only
> > handled one side of a wrap-around case in the ring.
> >
> > Fix the issue by doing a single iteration of the ring freeing all
> > buffers in it, handling wraparound through a simple post-increment check.
> >
> > Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx")
> > Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx")
> > Cc: wenzhuo.lu at intel.com
> > Cc: jingjing.wu at intel.com
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


More information about the stable mailing list